Externs generation: spit out src/-normalized path in generation messages

Externs generation: spit out src/-normalized path in generation messages

R=tbreisacher@chromium.org
BUG=729264
Review-Url: https://codereview.chromium.org/2915423002
Cr-Commit-Position: refs/heads/master@{#476851}
Committed: https://chromium.googlesource.com/chromium/src/+/8c18f1a1b60f5ad90b3de158558fb65279045e31

[Dan Beam, 2017-06-03 01:17:03]

Description was changed from

==========
Externs generation: spit out src/-normalized path in generation messages

R=tbreisacher@chromium.org
BUG=none
==========

to

==========
Externs generation: spit out src/-normalized path in generation messages

R=tbreisacher@chromium.org
BUG=729264
==========

[Devlin, 2017-06-03 01:21:26]

rdevlin.cronin@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Devlin, 2017-06-03 01:21:27]

lgtm

https://codereview.chromium.org/2915423002/diff/1/tools/json_schema_compiler/...
File tools/json_schema_compiler/js_externs_generator.py (right):

https://codereview.chromium.org/2915423002/diff/1/tools/json_schema_compiler/...
tools/json_schema_compiler/js_externs_generator.py:40: script_dir =
os.path.dirname(os.path.abspath(__file__))
nit: comments showing the translation here would be useful.

# /.../src/tools/json_schema_compiler/
script_dir = os.path.dirname(os.path.abspath(__file__))
# /.../src
src_root = os.path.normpath(os.path.join(script_dir, '..', '..'))
# tools/json_schema_compiler/
src_to_script = os.path.relpath(script_dir, src_root)
# tools/json_schema_compiler/compiler.py
compiler_path = os.path.join(src_to_script, 'compiler.py')

[Dan Beam, 2017-06-03 01:24:16]

https://codereview.chromium.org/2915423002/diff/1/tools/json_schema_compiler/...
File tools/json_schema_compiler/js_externs_generator.py (right):

https://codereview.chromium.org/2915423002/diff/1/tools/json_schema_compiler/...
tools/json_schema_compiler/js_externs_generator.py:40: script_dir =
os.path.dirname(os.path.abspath(__file__))
On 2017/06/03 01:21:27, Devlin wrote:
> nit: comments showing the translation here would be useful.
> 
> # /.../src/tools/json_schema_compiler/
> script_dir = os.path.dirname(os.path.abspath(__file__))
> # /.../src
> src_root = os.path.normpath(os.path.join(script_dir, '..', '..'))
> # tools/json_schema_compiler/
> src_to_script = os.path.relpath(script_dir, src_root)
> # tools/json_schema_compiler/compiler.py
> compiler_path = os.path.join(src_to_script, 'compiler.py')

Done.

[Dan Beam, 2017-06-03 01:24:41]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-06-03 01:24:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2915423002/#ps20001
(title: "path comments")

[commit-bot: I haz the power, 2017-06-03 01:25:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 01:38:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496453081489910,
"parent_rev": "442becce40151cd9b5450b98aa2327ba07424d2c", "commit_rev":
"8c18f1a1b60f5ad90b3de158558fb65279045e31"}

[commit-bot: I haz the power, 2017-06-03 01:38:29]

Description was changed from

==========
Externs generation: spit out src/-normalized path in generation messages

R=tbreisacher@chromium.org
BUG=729264
==========

to

==========
Externs generation: spit out src/-normalized path in generation messages

R=tbreisacher@chromium.org
BUG=729264

Review-Url: https://codereview.chromium.org/2915423002
Cr-Commit-Position: refs/heads/master@{#476851}
Committed:
https://chromium.googlesource.com/chromium/src/+/8c18f1a1b60f5ad90b3de158558f...
==========

[commit-bot: I haz the power, 2017-06-03 01:38:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8c18f1a1b60f5ad90b3de158558f...