Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2915283003:
Omnibox UI: Confine Cocoa suggestion lines to a single-line. (Closed)
|
Created:
3 years, 6 months ago by tommycli Modified:
3 years, 6 months ago Reviewers:
groby-ooo-7-16 CC:
chromium-reviews, jdonnelly+watch_chromium.org, mac-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionOmnibox UI: Confine Cocoa suggestion lines to a single-line.
Now that there vertical margins and vertical layout is possible, we
need to confine suggestion text to be rendered within a single line.
This was never a problem before since the whole cell could only fit
a single line, but this is necessary now.
BUG=725599
Review-Url: https://codereview.chromium.org/2915283003
Cr-Commit-Position: refs/heads/master@{#477709}
Committed: https://chromium.googlesource.com/chromium/src/+/8f997af7a224a5c15eece32f1dea70d5a3c676f3
Patch Set 1 #
Total comments: 2
Patch Set 2 : revert an erroneous change #Messages
Total messages: 21 (13 generated)
The CQ bit was checked by tommycli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tommycli@chromium.org changed reviewers: + groby@chromium.org
groby: PTAL. I noticed with vertical layout experiment, lines in the suggestions could overflow into multiple lines. I fixed it in this CL. https://codereview.chromium.org/2915283003/diff/1/chrome/browser/ui/cocoa/omn... File chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm (right): https://codereview.chromium.org/2915283003/diff/1/chrome/browser/ui/cocoa/omn... chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:571: forDarkTheme:isDarkTheme]; not strictly speaking related, but just fixing up something i noticed.
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by tommycli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
before and after screenshots: http://imgur.com/a/jBwTD https://codereview.chromium.org/2915283003/diff/1/chrome/browser/ui/cocoa/omn... File chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm (right): https://codereview.chromium.org/2915283003/diff/1/chrome/browser/ui/cocoa/omn... chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:571: forDarkTheme:isDarkTheme]; On 2017/06/02 23:35:07, tommycli wrote: > not strictly speaking related, but just fixing up something i noticed. Err nevermind, I realized it was correct the way it was before.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by groby@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/06/07 16:54:41, commit-bot: I haz the power wrote: > CQ is trying da patch. > > Follow status at: > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496858515940400,
"parent_rev": "1e531eb4ecf2fbf80ce97b92e00de76f46969c8a", "commit_rev":
"8f997af7a224a5c15eece32f1dea70d5a3c676f3"}
Message was sent while issue was closed.
Description was changed from ========== Omnibox UI: Confine Cocoa suggestion lines to a single-line. Now that there vertical margins and vertical layout is possible, we need to confine suggestion text to be rendered within a single line. This was never a problem before since the whole cell could only fit a single line, but this is necessary now. BUG=725599 ========== to ========== Omnibox UI: Confine Cocoa suggestion lines to a single-line. Now that there vertical margins and vertical layout is possible, we need to confine suggestion text to be rendered within a single line. This was never a problem before since the whole cell could only fit a single line, but this is necessary now. BUG=725599 Review-Url: https://codereview.chromium.org/2915283003 Cr-Commit-Position: refs/heads/master@{#477709} Committed: https://chromium.googlesource.com/chromium/src/+/8f997af7a224a5c15eece32f1dea... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8f997af7a224a5c15eece32f1dea... |
