Photo Picker dialog: Convert disabled test to Roboelectric.

Photo Picker dialog: Convert disabled test to Roboelectric.

BUG=728247, 656015
TBR=tedchoc

Review-Url: https://codereview.chromium.org/2915283002
Cr-Commit-Position: refs/heads/master@{#477401}
Committed: https://chromium.googlesource.com/chromium/src/+/85cc6600ed1c4403bea0a18ef801960bf54c1101

[Finnur, 2017-06-02 16:02:45]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[Finnur, 2017-06-02 16:03:14]

finnur@chromium.org changed reviewers:
+ twellington@chromium.org

[commit-bot: I haz the power, 2017-06-02 16:03:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2017-06-02 16:05:38]

This looks fine to me, but do we have any idea why the test was failing as a
junit4 test?

[commit-bot: I haz the power, 2017-06-02 16:43:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 16:43:09]

Dry run: This issue passed the CQ dry run.

[Finnur, 2017-06-06 11:13:09]

It was failing due to a pre-existing flakiness inherent in the setup code for
this junit4 test. I didn't notice that the only other test in this package had
already been disabled due to this error.

Both tests were failing in setup on a runOnUiThreadBlocking call, with the error
being:

java.util.concurrent.ExecutionException: junit.framework.AssertionFailedError:
Expecting scale factor of: 2.0, got: 1.0
at java.util.concurrent.FutureTask.report(FutureTask.java:94)
at java.util.concurrent.FutureTask.get(FutureTask.java:164)
at org.chromium.base.ThreadUtils.runOnUiThreadBlocking(ThreadUtils.java:79)

I didn't look into the failure since a Roboelectric test is anyway more
appropriate for testing small utility functions like this.

[Theresa, 2017-06-06 14:56:43]

lgtm

[Finnur, 2017-06-06 16:17:18]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2017-06-06 16:17:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 16:27:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 16:27:53]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Finnur, 2017-06-06 20:40:57]

Description was changed from

==========
Photo Picker dialog: Convert disabled test to Roboelectric.

BUG=728247, 656015
==========

to

==========
Photo Picker dialog: Convert disabled test to Roboelectric.

BUG=728247, 656015

TBR=tedchoc
==========

[Finnur, 2017-06-06 20:40:57]

finnur@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Finnur, 2017-06-06 20:41:45]

TBR-ing Ted, since it is a test I recently added that I'm converting to a
Roboelectric test.

[Finnur, 2017-06-06 20:41:51]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2017-06-06 20:42:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 20:48:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496781711293130, "parent_rev":
"8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46", "commit_rev":
"85cc6600ed1c4403bea0a18ef801960bf54c1101"}

[commit-bot: I haz the power, 2017-06-06 20:49:03]

Description was changed from

==========
Photo Picker dialog: Convert disabled test to Roboelectric.

BUG=728247, 656015

TBR=tedchoc
==========

to

==========
Photo Picker dialog: Convert disabled test to Roboelectric.

BUG=728247, 656015

TBR=tedchoc

Review-Url: https://codereview.chromium.org/2915283002
Cr-Commit-Position: refs/heads/master@{#477401}
Committed:
https://chromium.googlesource.com/chromium/src/+/85cc6600ed1c4403bea0a18ef801...
==========

[commit-bot: I haz the power, 2017-06-06 20:49:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/85cc6600ed1c4403bea0a18ef801...