DevTools: jsdoc for showToolbarPane in Elements

third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 13 matching lines @@
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 /**
  * @implements {UI.Searchable}
  * @implements {SDK.SDKModelObserver<!SDK.DOMModel>}
  * @implements {UI.ViewLocationResolver}
  * @unrestricted

[einbinder, 2017/06/03 01:52:44]

Remove unrestricted.

[luoe, 2017/06/05 19:03:21]

Sorry, my CL title was misleading.  I'm not adding jsdoc for the entire
ElementsPanel, just a few members that I planned to move in the next CL.  I
didn't want to do it in the other CL only because it was getting large and I
wanted to split this to be easier to review.

  */
 Elements.ElementsPanel = class extends UI.Panel {
   constructor() {
     super('elements');
     this.registerRequiredCSS('elements/elementsPanel.css');
 
     this._splitWidget = new UI.SplitWidget(true, true, 'elementsPanelSplitViewState', 325, 325);
     this._splitWidget.addEventListener(
         UI.SplitWidget.Events.SidebarSizeChanged, this._updateTreeOutlineVisibleWidth.bind(this));
     this._splitWidget.show(this.element);
@@ skipping 16 matching lines @@
     // FIXME: crbug.com/425984
     if (Common.moduleSetting('domWordWrap').get())
       this._contentElement.classList.add('elements-wrap');
     Common.moduleSetting('domWordWrap').addChangeListener(this._domWordWrapSettingChanged.bind(this));
 
     crumbsContainer.id = 'elements-crumbs';
     this._breadcrumbs = new Elements.ElementsBreadcrumbs();
     this._breadcrumbs.show(crumbsContainer);
     this._breadcrumbs.addEventListener(Elements.ElementsBreadcrumbs.Events.NodeSelected, this._crumbNodeSelected, this);
 
+    /** @type {?UI.Widget} */
     this._currentToolbarPane = null;
+    /** @type {?UI.Widget} */
+    this._animatedToolbarPane = null;
+    /** @type {?UI.Widget} */
+    this._pendingWidget = null;
+    /** @type {!UI.ToolbarToggle|undefined} */
+    this._pendingWidgetToggle;

[einbinder, 2017/06/03 01:52:44]

= null

[luoe, 2017/06/05 19:03:20]

Done.

 
     this._stylesWidget = new Elements.StylesSidebarPane();
     this._computedStyleWidget = new Elements.ComputedStyleWidget();
     this._metricsWidget = new Elements.MetricsSidebarPane();
 
     this._stylesSidebarToolbar = this._createStylesSidebarToolbar();
 
     Common.moduleSetting('sidebarPosition').addChangeListener(this._updateSidebarPosition.bind(this));
     this._updateSidebarPosition();
 
@@ skipping 59 matching lines @@
 
   /**
    * @param {?UI.Widget} widget
    * @param {!UI.ToolbarToggle=} toggle
    */
   showToolbarPane(widget, toggle) {
     if (this._pendingWidgetToggle)
       this._pendingWidgetToggle.setToggled(false);
     this._pendingWidgetToggle = toggle;
 
-    if (this._animatedToolbarPane !== undefined)
+    if (this._animatedToolbarPane)
       this._pendingWidget = widget;
     else
       this._startToolbarPaneAnimation(widget);
 
     if (widget && toggle)
       toggle.setToggled(true);
   }
 
   /**
    * @param {?UI.Widget} widget
@@ skipping 29 matching lines @@
     function onAnimationEnd() {
       this._toolbarPaneElement.style.removeProperty('animation-name');
       this._toolbarPaneElement.removeEventListener('animationend', listener, false);
 
       if (this._currentToolbarPane)
         this._currentToolbarPane.detach();
 
       this._currentToolbarPane = this._animatedToolbarPane;
       if (this._currentToolbarPane)
         this._currentToolbarPane.focus();
-      delete this._animatedToolbarPane;
+      this._animatedToolbarPane = null;
 
-      if (this._pendingWidget !== undefined) {
+      if (this._pendingWidget) {
         this._startToolbarPaneAnimation(this._pendingWidget);
-        delete this._pendingWidget;
+        this._pendingWidget = null;
       }
     }
   }
 
   /**
    * @override
    * @param {!SDK.DOMModel} domModel
    */
   modelAdded(domModel) {
     var treeOutline = new Elements.ElementsTreeOutline(domModel, true, true);
@@ skipping 855 matching lines @@
    * @param {!SDK.DOMNode} node
    * @return {?{title: string, color: string}}
    */
   decorate(node) {
     return {
       color: 'orange',
       title: Common.UIString('Element state: %s', ':' + node.domModel().cssModel().pseudoState(node).join(', :'))
     };
   }
 };