Description was changed from ========== Restore keyboard-lock tests BUG= ========== to ========== [System-Keyboard-Lock] Restore keyboard-lock ...
3 years, 6 months ago
(2017-06-02 17:57:29 UTC)
#3
Description was changed from
==========
Restore keyboard-lock tests
BUG=
==========
to
==========
[System-Keyboard-Lock] Restore keyboard-lock tests
The related test cases are removed by change
https://chromium-review.googlesource.com/c/499507/ because of a wrong annotation
in W3CImportExpectations file. The change to correct W3CImprotExpectations will
be submitted by change https://codereview.chromium.org/2916803004/. So this
change restores the original test files.
BUG=680809
==========
Description was changed from ========== [System-Keyboard-Lock] Restore keyboard-lock tests The related test cases are removed ...
3 years, 6 months ago
(2017-06-02 17:58:52 UTC)
#5
Description was changed from
==========
[System-Keyboard-Lock] Restore keyboard-lock tests
The related test cases are removed by change
https://chromium-review.googlesource.com/c/499507/ because of a wrong annotation
in W3CImportExpectations file. The change to correct W3CImprotExpectations will
be submitted by change https://codereview.chromium.org/2916803004/. So this
change restores the original test files.
BUG=680809
==========
to
==========
[System-Keyboard-Lock] Restore keyboard-lock tests
The related test cases are removed by change
https://chromium-review.googlesource.com/c/499507/ because of a wrong annotation
in W3CImportExpectations file. The change to correct W3CImprotExpectations will
be submitted by change https://codereview.chromium.org/2916803004/. So this
change restores the original test files.
BUG=680809
==========
Hzj_jie
3 years, 6 months ago
(2017-06-02 18:04:41 UTC)
#6
qyearsley
LGTM Above the BUG= line in the description, could you also add NOEXPORT=true? That way ...
3 years, 6 months ago
(2017-06-02 18:12:19 UTC)
#7
LGTM
Above the BUG= line in the description, could you also add NOEXPORT=true? That
way the wpt-exporter definitely won't consider this exportable.
I *think* that without that line, the exporter will look at this commit, and
check whether the patch applies to web-platform-tests HEAD (and it shouldn't
since these files already exist there), so I think it may be OK anyway, but
either way adding NOEXPORT=true will be correct.
Hzj_jie
Description was changed from ========== [System-Keyboard-Lock] Restore keyboard-lock tests The related test cases are removed ...
3 years, 6 months ago
(2017-06-02 18:13:29 UTC)
#8
Description was changed from
==========
[System-Keyboard-Lock] Restore keyboard-lock tests
The related test cases are removed by change
https://chromium-review.googlesource.com/c/499507/ because of a wrong annotation
in W3CImportExpectations file. The change to correct W3CImprotExpectations will
be submitted by change https://codereview.chromium.org/2916803004/. So this
change restores the original test files.
BUG=680809
==========
to
==========
[System-Keyboard-Lock] Restore keyboard-lock tests
The related test cases are removed by change
https://chromium-review.googlesource.com/c/499507/ because of a wrong annotation
in W3CImportExpectations file. The change to correct W3CImprotExpectations will
be submitted by change https://codereview.chromium.org/2916803004/. So this
change restores the original test files.
BUG=680809
NOEXPORT=true
==========
Hzj_jie
Description was changed from ========== [System-Keyboard-Lock] Restore keyboard-lock tests The related test cases are removed ...
3 years, 6 months ago
(2017-06-02 18:13:49 UTC)
#9
Description was changed from
==========
[System-Keyboard-Lock] Restore keyboard-lock tests
The related test cases are removed by change
https://chromium-review.googlesource.com/c/499507/ because of a wrong annotation
in W3CImportExpectations file. The change to correct W3CImprotExpectations will
be submitted by change https://codereview.chromium.org/2916803004/. So this
change restores the original test files.
BUG=680809
NOEXPORT=true
==========
to
==========
[System-Keyboard-Lock] Restore keyboard-lock tests
The related test cases are removed by change
https://chromium-review.googlesource.com/c/499507/ because of a wrong annotation
in W3CImportExpectations file. The change to correct W3CImprotExpectations will
be submitted by change https://codereview.chromium.org/2916803004/. So this
change restores the original test files.
NOEXPORT=true
BUG=680809
==========
Hzj_jie
On 2017/06/02 18:12:19, qyearsley wrote: > LGTM > > Above the BUG= line in the ...
3 years, 6 months ago
(2017-06-02 18:14:24 UTC)
#10
On 2017/06/02 18:12:19, qyearsley wrote:
> LGTM
>
> Above the BUG= line in the description, could you also add NOEXPORT=true? That
> way the wpt-exporter definitely won't consider this exportable.
>
> I *think* that without that line, the exporter will look at this commit, and
> check whether the patch applies to web-platform-tests HEAD (and it shouldn't
> since these files already exist there), so I think it may be OK anyway, but
> either way adding NOEXPORT=true will be correct.
Sorry for lacking knowledge about the exporter, I will follow your suggestion.
qyearsley
On 2017/06/02 at 18:14:24, zijiehe wrote: > On 2017/06/02 18:12:19, qyearsley wrote: > > LGTM ...
3 years, 6 months ago
(2017-06-02 18:16:01 UTC)
#11
On 2017/06/02 at 18:14:24, zijiehe wrote:
> On 2017/06/02 18:12:19, qyearsley wrote:
> > LGTM
> >
> > Above the BUG= line in the description, could you also add NOEXPORT=true?
That
> > way the wpt-exporter definitely won't consider this exportable.
> >
> > I *think* that without that line, the exporter will look at this commit, and
> > check whether the patch applies to web-platform-tests HEAD (and it shouldn't
> > since these files already exist there), so I think it may be OK anyway, but
> > either way adding NOEXPORT=true will be correct.
>
> Sorry for lacking knowledge about the exporter, I will follow your suggestion.
No problem, LGTM :-)
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago
(2017-06-02 19:08:29 UTC)
#12
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/470782)
3 years, 6 months ago
(2017-06-02 19:08:30 UTC)
#13
Issue 2915203003: [System-Keyboard-Lock] Restore keyboard-lock tests
(Closed)
Created 3 years, 6 months ago by Hzj_jie
Modified 3 years, 6 months ago
Reviewers: qyearsley
Base URL:
Comments: 0