Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2915203003: [System-Keyboard-Lock] Restore keyboard-lock tests (Closed)

Created:
3 years, 6 months ago by Hzj_jie
Modified:
3 years, 6 months ago
Reviewers:
qyearsley
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, jeffcarp
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[System-Keyboard-Lock] Restore keyboard-lock tests The related test cases are removed by change https://chromium-review.googlesource.com/c/499507/ because of a wrong annotation in W3CImportExpectations file. The change to correct W3CImprotExpectations will be submitted by change https://codereview.chromium.org/2916803004/. So this change restores the original test files. NOEXPORT=true BUG=680809 Review-Url: https://codereview.chromium.org/2915203003 Cr-Commit-Position: refs/heads/master@{#476843} Committed: https://chromium.googlesource.com/chromium/src/+/cc0c8cf835d5656666dbc7266d6f542d6607bc1f

Patch Set 1 #

Patch Set 2 : Workaround testharness.js test requirement #

Messages

Total messages: 23 (17 generated)
Hzj_jie
3 years, 6 months ago (2017-06-02 18:04:41 UTC) #6
qyearsley
LGTM Above the BUG= line in the description, could you also add NOEXPORT=true? That way ...
3 years, 6 months ago (2017-06-02 18:12:19 UTC) #7
Hzj_jie
On 2017/06/02 18:12:19, qyearsley wrote: > LGTM > > Above the BUG= line in the ...
3 years, 6 months ago (2017-06-02 18:14:24 UTC) #10
qyearsley
On 2017/06/02 at 18:14:24, zijiehe wrote: > On 2017/06/02 18:12:19, qyearsley wrote: > > LGTM ...
3 years, 6 months ago (2017-06-02 18:16:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915203003/20001
3 years, 6 months ago (2017-06-03 00:23:43 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-06-03 00:28:26 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cc0c8cf835d5656666dbc7266d6f...

Powered by Google App Engine
This is Rietveld 408576698