Add heartbeat timeout.

Add heartbeat timeout.

Added timeout for outgoing messages in remoting::HeartbeatSender.
XMPP connection is reset after 2 timed out heartbeats.

Also updated the class and the unittest to use constexpr TimeDelta
for all time constants.

BUG=728851
Review-Url: https://codereview.chromium.org/2915193003
Cr-Commit-Position: refs/heads/master@{#476744}
Committed: https://chromium.googlesource.com/chromium/src/+/b6e12e26514866f3e92bfed8725a3338f0e4409c

[Sergey Ulanov, 2017-06-01 23:12:40]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Sergey Ulanov, 2017-06-01 23:12:41]

Currently heartbeats are not retried after timeout. It simply logs an error and
disconnects XMPP after second timeout.
In a separate CL I'm going to simplify HeartbeatSender class a little, which
will allow to improve timeouts handling.

[Jamie, 2017-06-02 00:53:52]

LGTM modulo my comment about the length of the timeout.

https://codereview.chromium.org/2915193003/diff/1/remoting/host/heartbeat_sen...
File remoting/host/heartbeat_sender.cc (right):

https://codereview.chromium.org/2915193003/diff/1/remoting/host/heartbeat_sen...
remoting/host/heartbeat_sender.cc:54: base::TimeDelta::FromSeconds(10);
This seems a bit on the low side. IIRC, TCP timeout are typically closer to 30s;
any reason not to make this the same?

[Sergey Ulanov, 2017-06-02 18:37:01]

https://codereview.chromium.org/2915193003/diff/1/remoting/host/heartbeat_sen...
File remoting/host/heartbeat_sender.cc (right):

https://codereview.chromium.org/2915193003/diff/1/remoting/host/heartbeat_sen...
remoting/host/heartbeat_sender.cc:54: base::TimeDelta::FromSeconds(10);
On 2017/06/02 00:53:52, Jamie wrote:
> This seems a bit on the low side. IIRC, TCP timeout are typically closer to
30s;
> any reason not to make this the same?

Done.

[Sergey Ulanov, 2017-06-02 18:37:05]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2017-06-02 18:37:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/2915193003/#ps20001
(title: "30 seconds")

[commit-bot: I haz the power, 2017-06-02 18:37:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 19:11:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496428625383720,
"parent_rev": "a7dd7d63bd7cf1cdad65068ecb01da514954dfb6", "commit_rev":
"b6e12e26514866f3e92bfed8725a3338f0e4409c"}

[commit-bot: I haz the power, 2017-06-02 19:11:59]

Description was changed from

==========
Add heartbeat timeout.

Added timeout for outgoing messages in remoting::HeartbeatSender.
XMPP connection is reset after 2 timed out heartbeats.

Also updated the class and the unittest to use constexpr TimeDelta
for all time constants.

BUG=728851
==========

to

==========
Add heartbeat timeout.

Added timeout for outgoing messages in remoting::HeartbeatSender.
XMPP connection is reset after 2 timed out heartbeats.

Also updated the class and the unittest to use constexpr TimeDelta
for all time constants.

BUG=728851

Review-Url: https://codereview.chromium.org/2915193003
Cr-Commit-Position: refs/heads/master@{#476744}
Committed:
https://chromium.googlesource.com/chromium/src/+/b6e12e26514866f3e92bfed8725a...
==========

[commit-bot: I haz the power, 2017-06-02 19:12:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b6e12e26514866f3e92bfed8725a...