[DMC #28] Rename TextMatchMarker::State to LayoutStatus

Rename TextMatchMarker::State to LayoutStatus

Adding "Layout" to the name since we also have MatchStatus, and change State to
Status for consistency (they're both enums). I'm also reordering the
layout_status_ member variable to be above rendered_rect_ since whether or not
rendered_rect_ is currently valid depends on layout_status_.

BUG=707867
Review-Url: https://codereview.chromium.org/2915193002
Cr-Commit-Position: refs/heads/master@{#476693}
Committed: https://chromium.googlesource.com/chromium/src/+/7c8edfacd6a14a7da6d0977548a8009de764993c

[rlanday, 2017-06-01 20:33:41]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-06-01 20:33:51]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[commit-bot: I haz the power, 2017-06-01 20:34:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 23:33:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 23:33:38]

Dry run: This issue passed the CQ dry run.

[rlanday, 2017-06-02 01:24:20]

Description was changed from

==========
Rename TextMatchmarker::State to LayoutStatus

Adding "Layout" to the name since we also have MatchStatus, and change State to
Status for consistency (they're both enums). I'm also reordering the
layout_status_ member variable to be above rendered_rect_ since whether or not
rendered_rect_ is currently valid depends on layout_status_.

BUG=707867
==========

to

==========
Rename TextMatchMarker::State to LayoutStatus

Adding "Layout" to the name since we also have MatchStatus, and change State to
Status for consistency (they're both enums). I'm also reordering the
layout_status_ member variable to be above rendered_rect_ since whether or not
rendered_rect_ is currently valid depends on layout_status_.

BUG=707867
==========

[yosin_UTC9, 2017-06-02 01:36:48]

lgtm

Do you also want to rename |rendered_rect_| to |layout_rect_|?
"rendered" is old term and it is vague.

Chrome rendering pipeline does:
 - style update
 - layout
 - compositing
 - paint
 - CC does something

Note: |rendered_rect_| is populated after layout.

[rlanday, 2017-06-02 01:56:53]

On 2017/06/02 at 01:36:48, yosin wrote:
> lgtm
> 
> Do you also want to rename |rendered_rect_| to |layout_rect_|?
> "rendered" is old term and it is vague.
> 
> Chrome rendering pipeline does:
>  - style update
>  - layout
>  - compositing
>  - paint
>  - CC does something
> 
> Note: |rendered_rect_| is populated after layout.

We also have a bunch of methods we should probably rename at the same
time...maybe we can do this in another CL?

[rlanday, 2017-06-02 03:25:39]

The CQ bit was checked by rlanday@chromium.org

[commit-bot: I haz the power, 2017-06-02 03:25:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 03:36:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 03:36:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rlanday, 2017-06-02 15:11:08]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-06-02 15:11:08]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2915193002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-02 15:11:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 16:55:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496416268239640,
"parent_rev": "13b6a0f2fb8045004e2cd77c7e72947bae064d02", "commit_rev":
"7c8edfacd6a14a7da6d0977548a8009de764993c"}

[commit-bot: I haz the power, 2017-06-02 16:55:55]

Description was changed from

==========
Rename TextMatchMarker::State to LayoutStatus

Adding "Layout" to the name since we also have MatchStatus, and change State to
Status for consistency (they're both enums). I'm also reordering the
layout_status_ member variable to be above rendered_rect_ since whether or not
rendered_rect_ is currently valid depends on layout_status_.

BUG=707867
==========

to

==========
Rename TextMatchMarker::State to LayoutStatus

Adding "Layout" to the name since we also have MatchStatus, and change State to
Status for consistency (they're both enums). I'm also reordering the
layout_status_ member variable to be above rendered_rect_ since whether or not
rendered_rect_ is currently valid depends on layout_status_.

BUG=707867

Review-Url: https://codereview.chromium.org/2915193002
Cr-Commit-Position: refs/heads/master@{#476693}
Committed:
https://chromium.googlesource.com/chromium/src/+/7c8edfacd6a14a7da6d0977548a8...
==========

[commit-bot: I haz the power, 2017-06-02 16:55:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7c8edfacd6a14a7da6d0977548a8...