Chromium Code Reviews| Index: chrome/browser/ui/webui/signin/user_manager_screen_handler.cc |
| diff --git a/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc b/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc |
| index d608631d9553445af7dfb82405d627ad9b857cd9..97b8cee512e891966adba0a178b33b87715a2325 100644 |
| --- a/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc |
| +++ b/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc |
| @@ -635,9 +635,9 @@ void UserManagerScreenHandler::RemoveUserDialogLoadStatsCallback( |
| // Copy result into return_value. |
| base::DictionaryValue return_value; |
| for (const auto& item : result) { |
| - std::unique_ptr<base::DictionaryValue> stat(new base::DictionaryValue); |
| + auto stat = base::MakeUnique<base::DictionaryValue>(); |
| stat->SetIntegerWithoutPathExpansion("count", item.count); |
| - stat->SetBooleanWithoutPathExpansion("success", item.success); |
| + stat->SetIntegerWithoutPathExpansion("success", true); |
|
michaelpg
2017/06/07 18:25:54
should this be removed as well? if not, why Boolea
dullweber
2017/06/08 10:55:55
oh, thanks for catching this.
I removed it at fir
|
| return_value.SetWithoutPathExpansion(item.category, std::move(stat)); |
| } |
| if (result.size() == profiles::kProfileStatisticsCategories.size()) { |
| @@ -805,8 +805,9 @@ void UserManagerScreenHandler::GetLocalizedValues( |
| l10n_util::GetStringUTF16(IDS_LOGIN_POD_USER_REMOVE_WARNING_PASSWORDS)); |
| localized_strings->SetString("removeUserWarningTextBookmarks", |
| l10n_util::GetStringUTF16(IDS_LOGIN_POD_USER_REMOVE_WARNING_BOOKMARKS)); |
| - localized_strings->SetString("removeUserWarningTextSettings", |
| - l10n_util::GetStringUTF16(IDS_LOGIN_POD_USER_REMOVE_WARNING_SETTINGS)); |
| + localized_strings->SetString( |
| + "removeUserWarningTextAutofill", |
| + l10n_util::GetStringUTF16(IDS_LOGIN_POD_USER_REMOVE_WARNING_AUTOFILL)); |
| localized_strings->SetString("removeUserWarningTextCalculating", |
| l10n_util::GetStringUTF16(IDS_LOGIN_POD_USER_REMOVE_WARNING_CALCULATING)); |
| localized_strings->SetString("removeUserWarningTextSyncNoStats", |