Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2915033002: [Cronet] Fix two races/leaks in JavaUrlRequest (Closed)

Created:
3 years, 6 months ago by pauljensen
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[Cronet] Fix two races/leaks in JavaUrlRequest The underlying InputStream and HttpURLConnection were accessed on different threads which during cancellation could result in races resulting in leaks that StrictMode catches. Shift all accesses to these variables to one thread like the Chromium threading principles recommends. BUG=726193 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2903193002 Cr-Original-Commit-Position: refs/heads/master@{#475945} Review-Url: https://codereview.chromium.org/2915033002 . Cr-Commit-Position: refs/branch-heads/3112@{#87} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/8a145da80cb326dca497d43777003498ac38e2a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -73 lines) Patch
M components/cronet/android/java/src/org/chromium/net/impl/JavaUrlRequest.java View 8 chunks +39 lines, -47 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java View 3 chunks +25 lines, -0 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java View 1 chunk +35 lines, -0 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/UploadDataProvidersTest.java View 3 chunks +5 lines, -26 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pauljensen
3 years, 6 months ago (2017-06-01 13:05:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a145da80cb326dca497d43777003498ac38e2a4.

Powered by Google App Engine
This is Rietveld 408576698