Remove most of chrome/ and content/ usage from TranslateInfoBarDelegate

Remove most of chrome/ and content/ usage from TranslateInfoBarDelegate

The only problematic dependencies left are WebContents (only needed for
the GetWebContents() method, which is only used by OptionsMenuModel),
and InfoBarService, which is only used to implement GetWebContents().

BUG=371845
TBR=rohitrao

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271205

[blundell, 2014-05-16 14:44:33]

LG

https://codereview.chromium.org/291503008/diff/10007/chrome/browser/translate...
File chrome/browser/translate/translate_infobar_delegate.h (right):

https://codereview.chromium.org/291503008/diff/10007/chrome/browser/translate...
chrome/browser/translate/translate_infobar_delegate.h:57: TranslateManager*
translate_manager,
I think it would be clearer to have the WeakPtr transformation happen before
this call, i.e., this method (and all the ones further in the chain) take in a
WeakPtr. WDYT?

[droger, 2014-05-16 15:09:38]

Thanks, please take a look.

[blundell, 2014-05-16 15:11:02]

LGTM

https://codereview.chromium.org/291503008/diff/40001/chrome/browser/translate...
File chrome/browser/translate/translate_infobar_delegate.cc (right):

https://codereview.chromium.org/291503008/diff/40001/chrome/browser/translate...
chrome/browser/translate/translate_infobar_delegate.cc:329:
translate_manager.get(),
hmm, is it ok that this guy holds on to a raw pointer? could address in followup
if it's actually a problem since you're not changing the existing situation.

[droger, 2014-05-16 15:14:11]

TBR= rohitrao as owner of
chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm

https://codereview.chromium.org/291503008/diff/40001/chrome/browser/translate...
File chrome/browser/translate/translate_infobar_delegate.cc (right):

https://codereview.chromium.org/291503008/diff/40001/chrome/browser/translate...
chrome/browser/translate/translate_infobar_delegate.cc:329:
translate_manager.get(),
On 2014/05/16 15:11:03, blundell wrote:
> hmm, is it ok that this guy holds on to a raw pointer? could address in
followup
> if it's actually a problem since you're not changing the existing situation.

You're right, it's probably not OK conceptually.

[droger, 2014-05-16 15:14:44]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2014-05-16 15:15:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/droger@chromium.org/291503008/40001

[rohitrao (ping after 24h), 2014-05-16 15:45:20]

cocoa/ code LGTM

[blundell, 2014-05-16 15:45:43]

Hi Rohit!

[commit-bot: I haz the power, 2014-05-16 17:12:29]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-16 18:12:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 18:12:04]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[droger, 2014-05-16 22:04:27]

The CQ bit was unchecked by droger@chromium.org

[droger, 2014-05-16 22:04:27]

The CQ bit was checked by droger@chromium.org

[droger, 2014-05-16 22:45:39]

The CQ bit was unchecked by droger@chromium.org

[droger, 2014-05-16 22:45:52]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2014-05-16 23:32:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/droger@chromium.org/291503008/40001

[commit-bot: I haz the power, 2014-05-17 15:34:26]

Change committed as 271205