chrome/browser/translate/translate_tab_helper.cc - Issue 291503008: Remove most of chrome/ and content/ usage from TranslateInfoBarDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_tab_helper.cc

Issue 291503008: Remove most of chrome/ and content/ usage from TranslateInfoBarDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/translate/translate_infobar_delegate.cc ('K') | « chrome/browser/translate/translate_infobar_delegate.cc ('k') | chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/translate/translate_tab_helper.cc

diff --git a/chrome/browser/translate/translate_tab_helper.cc b/chrome/browser/translate/translate_tab_helper.cc

index 4fab0728da9643b95e2327f9542744d388f105f9..813b82a0779019fc5ff868fcff2231d96af020df 100644

--- a/chrome/browser/translate/translate_tab_helper.cc

+++ b/chrome/browser/translate/translate_tab_helper.cc

@@ -8,6 +8,7 @@

#include "base/prefs/pref_service.h"

#include "base/strings/string_split.h"

#include "chrome/browser/chrome_notification_types.h"

+#include "chrome/browser/infobars/infobar_service.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/translate/translate_accept_languages_factory.h"

#include "chrome/browser/translate/translate_infobar_delegate.h"

@@ -177,7 +178,9 @@ void TranslateTabHelper::ShowTranslateUI(translate::TranslateStep step,

Profile* original_profile = profile->GetOriginalProfile();

TranslateInfoBarDelegate::Create(

step != translate::TRANSLATE_STEP_BEFORE_TRANSLATE,

- web_contents(),

+ translate_manager_->GetWeakPtr(),

+ InfoBarService::FromWebContents(web_contents()),

+ profile->IsOffTheRecord(),

step,

source_language,

target_language,