Make all PaintLayers that scroll overflow self-painting.

Make all PaintLayers that scroll overflow self-painting.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2915013004
Cr-Commit-Position: refs/heads/master@{#477161}
Committed: https://chromium.googlesource.com/chromium/src/+/351b6fecd66235ac6e00e873266da5be47bf370e

[chrishtr, 2017-06-02 00:11:07]

Description was changed from

==========
none

BUG=
==========

to

==========
none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-06-02 00:11:37]

Description was changed from

==========
none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Make all PaintLayers that scroll overflow self-painting.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-06-02 00:11:51]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 00:13:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 01:22:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 01:22:13]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2017-06-02 05:14:00]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 05:14:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 06:25:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 06:25:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2017-06-02 16:27:23]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 16:27:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-06-02 16:27:47]

chrishtr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:26:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:26:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2017-06-02 21:05:56]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[chrishtr, 2017-06-02 21:06:04]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2017-06-02 21:07:51]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 21:08:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 22:12:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 22:12:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2017-06-03 01:51:30]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[chrishtr, 2017-06-03 01:51:47]

Ping- this is ready for review.

[commit-bot: I haz the power, 2017-06-03 01:51:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 04:01:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-03 04:01:15]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2017-06-03 04:10:21]

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
(right):

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:114:
Bug(none)
virtual/new-remote-playback-pipeline/media/controls/controls-cast-do-not-fade-out.html
[ Failure ]
I saw it crashed with and without patch, so we should expect [ Crash ] instead
of [ Failure ].

It's seems unrelated to this CL. We should update this in another patch. I can
update this in my spv2 rebaseline patch.

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:1030: crbug.com/728923
virtual/disable-spinvalidation/paint/invalidation/textarea-caret.html [
NeedsRebaseline ]
I guess webkit-patch rebaseline-cl should work?

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/fast/forms/select/listbox-selection-2.html
(left):

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/forms/select/listbox-selection-2.html:80:
shouldBe('selectionPattern("sl1")', '"00000001000000000"');
Why remove this?

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintLayer.cpp (left):

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayer.cpp:2906:
NeedsCompositedScrolling();
Was there anything preventing us from letting all scrolling layers be
self-painting?

[chrishtr, 2017-06-05 17:23:07]

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
(right):

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:114:
Bug(none)
virtual/new-remote-playback-pipeline/media/controls/controls-cast-do-not-fade-out.html
[ Failure ]
On 2017/06/03 at 04:10:20, Xianzhu wrote:
> I saw it crashed with and without patch, so we should expect [ Crash ] instead
> of [ Failure ].
> 
> It's seems unrelated to this CL. We should update this in another patch. I can
update this in my spv2 rebaseline patch.

I can remove it or land in a separate patch.

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:1030: crbug.com/728923
virtual/disable-spinvalidation/paint/invalidation/textarea-caret.html [
NeedsRebaseline ]
On 2017/06/03 at 04:10:20, Xianzhu wrote:
> I guess webkit-patch rebaseline-cl should work?

I tried it and it did not work. :(

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/fast/forms/select/listbox-selection-2.html
(left):

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/forms/select/listbox-selection-2.html:80:
shouldBe('selectionPattern("sl1")', '"00000001000000000"');
On 2017/06/03 at 04:10:21, Xianzhu wrote:
> Why remove this?

Item 8 is not visible without scrolling. Therefore I think it
was an accident/quirk of non-PaintLayer hit testing that it passed before.

[Xianzhu, 2017-06-05 17:27:52]

lgtm

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
(right):

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:114:
Bug(none)
virtual/new-remote-playback-pipeline/media/controls/controls-cast-do-not-fade-out.html
[ Failure ]
On 2017/06/05 17:23:07, chrishtr wrote:
> On 2017/06/03 at 04:10:20, Xianzhu wrote:
> > I saw it crashed with and without patch, so we should expect [ Crash ]
instead
> > of [ Failure ].
> > 
> > It's seems unrelated to this CL. We should update this in another patch. I
can
> update this in my spv2 rebaseline patch.
> 
> I can remove it or land in a separate patch.

Please remove it. As it fails with or without patch, it won't block CQ.

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:1030: crbug.com/728923
virtual/disable-spinvalidation/paint/invalidation/textarea-caret.html [
NeedsRebaseline ]
On 2017/06/05 17:23:07, chrishtr wrote:
> On 2017/06/03 at 04:10:20, Xianzhu wrote:
> > I guess webkit-patch rebaseline-cl should work?
> 
> I tried it and it did not work. :(

What was the error?

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/fast/forms/select/listbox-selection-2.html
(left):

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/forms/select/listbox-selection-2.html:80:
shouldBe('selectionPattern("sl1")', '"00000001000000000"');
On 2017/06/05 17:23:07, chrishtr wrote:
> On 2017/06/03 at 04:10:21, Xianzhu wrote:
> > Why remove this?
> 
> Item 8 is not visible without scrolling. Therefore I think it
> was an accident/quirk of non-PaintLayer hit testing that it passed before.

Acknowledged.

[chrishtr, 2017-06-05 18:06:45]

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
(right):

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:114:
Bug(none)
virtual/new-remote-playback-pipeline/media/controls/controls-cast-do-not-fade-out.html
[ Failure ]
On 2017/06/05 at 17:27:51, Xianzhu wrote:
> On 2017/06/05 17:23:07, chrishtr wrote:
> > On 2017/06/03 at 04:10:20, Xianzhu wrote:
> > > I saw it crashed with and without patch, so we should expect [ Crash ]
instead
> > > of [ Failure ].
> > > 
> > > It's seems unrelated to this CL. We should update this in another patch. I
can
> > update this in my spv2 rebaseline patch.
> > 
> > I can remove it or land in a separate patch.
> 
> Please remove it. As it fails with or without patch, it won't block CQ.

Done.

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2915013004/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:1030: crbug.com/728923
virtual/disable-spinvalidation/paint/invalidation/textarea-caret.html [
NeedsRebaseline ]
On 2017/06/05 at 17:27:52, Xianzhu wrote:
> On 2017/06/05 17:23:07, chrishtr wrote:
> > On 2017/06/03 at 04:10:20, Xianzhu wrote:
> > > I guess webkit-patch rebaseline-cl should work?
> > 
> > I tried it and it did not work. :(
> 
> What was the error?

I don't remember. Will try again in the latest patchset.

[chrishtr, 2017-06-05 21:34:17]

Looks like the rebaseline worked this time. Committing.

[chrishtr, 2017-06-05 21:34:19]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-06-05 21:34:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2915013004/#ps180001
(title: "none")

[commit-bot: I haz the power, 2017-06-05 21:35:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 22:44:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 22:44:35]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2017-06-06 00:16:10]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-06-06 00:17:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 02:44:33]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1496708170382760,
"parent_rev": "1192df1565e6591124601a249336a0879d0f4d09", "commit_rev":
"351b6fecd66235ac6e00e873266da5be47bf370e"}

[commit-bot: I haz the power, 2017-06-06 02:44:45]

Description was changed from

==========
Make all PaintLayers that scroll overflow self-painting.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Make all PaintLayers that scroll overflow self-painting.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2915013004
Cr-Commit-Position: refs/heads/master@{#477161}
Committed:
https://chromium.googlesource.com/chromium/src/+/351b6fecd66235ac6e00e873266d...
==========

[commit-bot: I haz the power, 2017-06-06 02:44:47]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/351b6fecd66235ac6e00e873266d...