Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2914973002: [EasyUnlock] Remove unnecessary logging. (Closed)

Created:
3 years, 6 months ago by Tim Song
Modified:
3 years, 6 months ago
Reviewers:
sacomoto
CC:
chromium-reviews, Lei Zhang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[EasyUnlock] Remove unnecessary logging. Review-Url: https://codereview.chromium.org/2914973002 Cr-Commit-Position: refs/heads/master@{#476394} Committed: https://chromium.googlesource.com/chromium/src/+/16abbb1477d2724bcf73bfdef84e9e7a470efc9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/signin/easy_unlock_app_manager.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Tim Song
3 years, 6 months ago (2017-05-31 23:52:49 UTC) #2
sacomoto
lgtm
3 years, 6 months ago (2017-06-01 13:57:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914973002/1
3 years, 6 months ago (2017-06-01 17:15:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/380741) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 6 months ago (2017-06-01 17:22:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914973002/1
3 years, 6 months ago (2017-06-01 18:45:35 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 19:45:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/16abbb1477d2724bcf73bfdef84e...

Powered by Google App Engine
This is Rietveld 408576698