Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2914963003: Unify if guards of GetLinuxWindowManager. (Closed)

Created:
3 years, 6 months ago by timbrown
Modified:
3 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify if guards of GetLinuxWindowManager. This comes from a review comment on http://crrev.com/2917483002. The if guard on the function call to GetLinuxWindowManager is no longer the same as the guard of the function definition. This CL makes them the same again. BUG=724244 R=thestig@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ozone_compile_only_ng Review-Url: https://codereview.chromium.org/2914963003 Cr-Commit-Position: refs/heads/master@{#476481} Committed: https://chromium.googlesource.com/chromium/src/+/3612567b1d18726aa2acc3b477c615f98c016c0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
timbrown
3 years, 6 months ago (2017-06-01 21:26:38 UTC) #2
Lei Zhang
lgtm
3 years, 6 months ago (2017-06-01 21:41:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914963003/1
3 years, 6 months ago (2017-06-01 23:13:39 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 23:20:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3612567b1d18726aa2acc3b477c6...

Powered by Google App Engine
This is Rietveld 408576698