Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2914923002: Fixing removing entries from DUA too early. (Closed)

Created:
3 years, 6 months ago by RyanSturm
Modified:
3 years, 6 months ago
Reviewers:
tbansal1
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing removing entries from DUA too early. BUG= Review-Url: https://codereview.chromium.org/2914923002 Cr-Commit-Position: refs/heads/master@{#476449} Committed: https://chromium.googlesource.com/chromium/src/+/9b84dcccaf1f37795932de1298d6c46bb4e2e73a

Patch Set 1 #

Patch Set 2 : git cl try #

Patch Set 3 : test #

Total comments: 2

Patch Set 4 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -24 lines) Patch
M chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc View 1 2 3 1 chunk +20 lines, -14 lines 0 comments Download
M chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc View 1 2 2 chunks +74 lines, -2 lines 0 comments Download
M components/data_use_measurement/core/data_use_recorder.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/data_use_measurement/core/data_use_recorder.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
RyanSturm
tbansal: PTAL
3 years, 6 months ago (2017-06-01 20:11:12 UTC) #10
tbansal1
lgtm https://codereview.chromium.org/2914923002/diff/40001/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc File chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc (right): https://codereview.chromium.org/2914923002/diff/40001/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc#newcode206 chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc:206: // For non-main frame requests, the page load ...
3 years, 6 months ago (2017-06-01 20:24:22 UTC) #11
RyanSturm
https://codereview.chromium.org/2914923002/diff/40001/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc File chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc (right): https://codereview.chromium.org/2914923002/diff/40001/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc#newcode206 chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc:206: // For non-main frame requests, the page load can ...
3 years, 6 months ago (2017-06-01 21:59:18 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914923002/60001
3 years, 6 months ago (2017-06-01 22:00:02 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 22:05:52 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9b84dcccaf1f37795932de1298d6...

Powered by Google App Engine
This is Rietveld 408576698