[Mac] Enable AppNap for renderers

[Mac] Enable AppNap for renderers

TEST=Run with --enable-features="MacAllowBackgroundingProcesses<MacAllowBackgroundingProcesses" --force-fieldtrials=MacAllowBackgroundingProcesses/Enabled --force-fieldtrial-params=MacAllowBackgroundingProcesses.Enabled:app_nap/true

BUG=460102
Review-Url: https://codereview.chromium.org/2914913002
Cr-Commit-Position: refs/heads/master@{#478049}
Committed: https://chromium.googlesource.com/chromium/src/+/023fd36f8333a24124c9f8071303aba913392704

[lgrey, 2017-06-02 16:06:17]

The CQ bit was checked by lgrey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 16:06:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 17:40:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:40:59]

Dry run: This issue passed the CQ dry run.

[lgrey, 2017-06-02 18:58:24]

Description was changed from

==========
[WIP NOT FOR REVIEW][Mac] Enable AppNap for renderers

BUG=460102
==========

to

==========
[Mac] Enable AppNap for renderers

TEST=Run with
--enable-features="MacAllowBackgroundingProcesses<MacAllowBackgroundingProcesses"
--force-fieldtrials=MacAllowBackgroundingProcesses/Enabled
--force-fieldtrial-params=MacAllowBackgroundingProcesses.Enabled:app_nap/true

BUG=460102
==========

[lgrey, 2017-06-02 18:58:49]

lgrey@chromium.org changed reviewers:
+ rsesek@chromium.org, shrike@chromium.org

[lgrey, 2017-06-02 18:58:50]

PTAL :)

[Robert Sesek, 2017-06-02 19:26:36]

LGTM!

https://codereview.chromium.org/2914913002/diff/60001/chrome/app/helper-Info....
File chrome/app/helper-Info.plist (right):

https://codereview.chromium.org/2914913002/diff/60001/chrome/app/helper-Info....
chrome/app/helper-Info.plist:31: <key>NSSupportsAutomaticTermination</key>
Do we want this key? Based on
https://developer.apple.com/library/content/documentation/General/Reference/I...
I'm not sure.

[shrike, 2017-06-02 19:57:53]

https://codereview.chromium.org/2914913002/diff/60001/chrome/app/helper-Info....
File chrome/app/helper-Info.plist (right):

https://codereview.chromium.org/2914913002/diff/60001/chrome/app/helper-Info....
chrome/app/helper-Info.plist:31: <key>NSSupportsAutomaticTermination</key>
On 2017/06/02 19:26:36, Robert Sesek wrote:
> Do we want this key? Based on

I don't think we do.

https://codereview.chromium.org/2914913002/diff/60001/content/common/mac/app_...
File content/common/mac/app_nap_activity.mm (right):

https://codereview.chromium.org/2914913002/diff/60001/content/common/mac/app_...
content/common/mac/app_nap_activity.mm:51: 0x3b000000, @"Finished delay after
app launch and bundle check", 0);
Can 0x3b000000 be defined as a constant with a reasonably descriptive name, or
is this a completely magic number?

[lgrey, 2017-06-05 14:49:43]

https://codereview.chromium.org/2914913002/diff/60001/chrome/app/helper-Info....
File chrome/app/helper-Info.plist (right):

https://codereview.chromium.org/2914913002/diff/60001/chrome/app/helper-Info....
chrome/app/helper-Info.plist:31: <key>NSSupportsAutomaticTermination</key>
On 2017/06/02 19:57:53, shrike wrote:
> On 2017/06/02 19:26:36, Robert Sesek wrote:
> > Do we want this key? Based on
> 
> I don't think we do.

Done.

https://codereview.chromium.org/2914913002/diff/60001/content/common/mac/app_...
File content/common/mac/app_nap_activity.mm (right):

https://codereview.chromium.org/2914913002/diff/60001/content/common/mac/app_...
content/common/mac/app_nap_activity.mm:51: 0x3b000000, @"Finished delay after
app launch and bundle check", 0);
On 2017/06/02 19:57:53, shrike wrote:
> Can 0x3b000000 be defined as a constant with a reasonably descriptive name, or
> is this a completely magic number?

It's magic to us, unfortunately (as is the "1" in the previous call)
https://github.com/phracker/MacOSX-SDKs/blob/master/MacOSX10.10.sdk/System/Li...

[shrike, 2017-06-05 15:29:36]

https://codereview.chromium.org/2914913002/diff/60001/content/common/mac/app_...
File content/common/mac/app_nap_activity.mm (right):

https://codereview.chromium.org/2914913002/diff/60001/content/common/mac/app_...
content/common/mac/app_nap_activity.mm:51: 0x3b000000, @"Finished delay after
app launch and bundle check", 0);
On 2017/06/05 14:49:43, lgrey wrote:
> It's magic to us, unfortunately (as is the "1" in the previous call)
>
https://github.com/phracker/MacOSX-SDKs/blob/master/MacOSX10.10.sdk/System/Li...

So is it an "or" of NSActivity flags? If so, can you replace the naked magic
number with an or of those flags?

[lgrey, 2017-06-05 15:56:29]

On 2017/06/05 15:29:36, shrike wrote:
>
https://codereview.chromium.org/2914913002/diff/60001/content/common/mac/app_...
> File content/common/mac/app_nap_activity.mm (right):
> 
>
https://codereview.chromium.org/2914913002/diff/60001/content/common/mac/app_...
> content/common/mac/app_nap_activity.mm:51: 0x3b000000, @"Finished delay after
> app launch and bundle check", 0);
> On 2017/06/05 14:49:43, lgrey wrote:
> > It's magic to us, unfortunately (as is the "1" in the previous call)
> >
>
https://github.com/phracker/MacOSX-SDKs/blob/master/MacOSX10.10.sdk/System/Li...
> 
> So is it an "or" of NSActivity flags? If so, can you replace the naked magic
> number with an or of those flags?

Given the values, we're reasonably sure there's no permutation of the public
flags that gets us to either of those.

[shrike, 2017-06-05 17:24:39]

On 2017/06/05 15:56:29, lgrey wrote:
> Given the values, we're reasonably sure there's no permutation of the public
> flags that gets us to either of those.

OK - can you please add a comment mentioning that it's a magic number (and as
much info as you can about how it was derived)? Other than that, lgtm

[lgrey, 2017-06-05 20:19:21]

On 2017/06/05 17:24:39, shrike wrote:
> On 2017/06/05 15:56:29, lgrey wrote:
> > Given the values, we're reasonably sure there's no permutation of the public
> > flags that gets us to either of those.
> 
> OK - can you please add a comment mentioning that it's a magic number (and as
> much info as you can about how it was derived)? Other than that, lgtm

Done

[Robert Sesek, 2017-06-05 21:03:29]

LGTM

[lgrey, 2017-06-06 15:20:00]

The CQ bit was checked by lgrey@chromium.org

[lgrey, 2017-06-06 15:20:00]

The patchset sent to the CQ was uploaded after l-g-t-m from shrike@chromium.org
Link to the patchset: https://codereview.chromium.org/2914913002/#ps100001
(title: "Add comment for magic numbers")

[commit-bot: I haz the power, 2017-06-06 15:20:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgrey, 2017-06-06 15:20:16]

The CQ bit was unchecked by lgrey@chromium.org

[lgrey, 2017-06-06 15:23:14]

lgrey@chromium.org changed reviewers:
+ avi@chromium.org, mark@chromium.org, rockot@chromium.org

[lgrey, 2017-06-06 15:23:15]

Thanks!

+ mark@ for base/OWNERS
+ rockot@ for chrome/app/OWNERS
+ avi@ for content/OWNERS

[Avi (use Gerrit), 2017-06-06 15:27:27]

lgtm

Magic!

[Mark Mentovai, 2017-06-06 16:16:09]

LGTM

[Ken Rockot(use gerrit already), 2017-06-08 17:28:49]

lgtm

[lgrey, 2017-06-08 17:45:06]

The CQ bit was checked by lgrey@chromium.org

[lgrey, 2017-06-08 17:45:08]

The CQ bit was unchecked by lgrey@chromium.org

[lgrey, 2017-06-08 17:45:19]

The CQ bit was checked by lgrey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 17:45:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 19:14:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 19:14:26]

Dry run: This issue passed the CQ dry run.

[lgrey, 2017-06-08 19:15:56]

The CQ bit was checked by lgrey@chromium.org

[commit-bot: I haz the power, 2017-06-08 19:16:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 19:20:55]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1496949356113420,
"parent_rev": "fe8f969833ed376460af94787e2572755e598575", "commit_rev":
"023fd36f8333a24124c9f8071303aba913392704"}

[commit-bot: I haz the power, 2017-06-08 19:21:10]

Description was changed from

==========
[Mac] Enable AppNap for renderers

TEST=Run with
--enable-features="MacAllowBackgroundingProcesses<MacAllowBackgroundingProcesses"
--force-fieldtrials=MacAllowBackgroundingProcesses/Enabled
--force-fieldtrial-params=MacAllowBackgroundingProcesses.Enabled:app_nap/true

BUG=460102
==========

to

==========
[Mac] Enable AppNap for renderers

TEST=Run with
--enable-features="MacAllowBackgroundingProcesses<MacAllowBackgroundingProcesses"
--force-fieldtrials=MacAllowBackgroundingProcesses/Enabled
--force-fieldtrial-params=MacAllowBackgroundingProcesses.Enabled:app_nap/true

BUG=460102

Review-Url: https://codereview.chromium.org/2914913002
Cr-Commit-Position: refs/heads/master@{#478049}
Committed:
https://chromium.googlesource.com/chromium/src/+/023fd36f8333a24124c9f8071303...
==========

[commit-bot: I haz the power, 2017-06-08 19:21:12]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/023fd36f8333a24124c9f8071303...