Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2914903002: memory-infra: Fix a unit conversion error for private memory footprint. (Closed)

Created:
3 years, 6 months ago by erikchen
Modified:
3 years, 6 months ago
CC:
chromium-reviews, awong
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

memory-infra: Fix a unit conversion error for private memory footprint. Bytes were being converted to kilobytes without a division. BUG=707022 Review-Url: https://codereview.chromium.org/2914903002 Cr-Commit-Position: refs/heads/master@{#476241} Committed: https://chromium.googlesource.com/chromium/src/+/1564e791a8a6678d9c550bf4acb78500a4c19d05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M services/resource_coordinator/memory_instrumentation/coordinator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
erikchen
primiano: Please review.
3 years, 6 months ago (2017-05-31 20:19:33 UTC) #2
awong
LGTM derp.
3 years, 6 months ago (2017-05-31 20:24:18 UTC) #6
Primiano Tucci (use gerrit)
LGTM. took the liberty of adding "memory-infra: " to the cl title for clarify before ...
3 years, 6 months ago (2017-06-01 10:00:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914903002/1
3 years, 6 months ago (2017-06-01 10:00:34 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 10:05:26 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1564e791a8a6678d9c550bf4acb7...

Powered by Google App Engine
This is Rietveld 408576698