Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2914853002:
Change BidirectionalStreamQuicImplTest to verify the correct callback (Closed)
|
Created:
3 years, 6 months ago by Ryan Hamilton Modified:
3 years, 6 months ago Reviewers:
xunjieli CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange BidirectionalStreamQuicImplTest to verify the correct callback
is invoked instead of relying on comments.
BUG=716563
Review-Url: https://codereview.chromium.org/2914853002
Cr-Commit-Position: refs/heads/master@{#476193}
Committed: https://chromium.googlesource.com/chromium/src/+/4f176c786029e5b60a5c579efc752d3586a6c594
Patch Set 1 : Cleanup #Patch Set 2 : Rebase #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 24 (18 generated)
rch@chromium.org changed reviewers: + xunjieli@chromium.org
Patchset #1 (id:1) has been deleted
lgtm
The CQ bit was checked by rch@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by rch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
Patchset #2 (id:40001) has been deleted
Patchset #2 (id:60001) has been deleted
The CQ bit was checked by rch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rch@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xunjieli@chromium.org Link to the patchset: https://codereview.chromium.org/2914853002/#ps80001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496292566225660,
"parent_rev": "12cdf8017a99e246e8acff7c3512fbd4406cafe0", "commit_rev":
"4f176c786029e5b60a5c579efc752d3586a6c594"}
Message was sent while issue was closed.
Description was changed from ========== Change BidirectionalStreamQuicImplTest to verify the correct callback is invoked instead of relying on comments. BUG=716563 ========== to ========== Change BidirectionalStreamQuicImplTest to verify the correct callback is invoked instead of relying on comments. BUG=716563 Review-Url: https://codereview.chromium.org/2914853002 Cr-Commit-Position: refs/heads/master@{#476193} Committed: https://chromium.googlesource.com/chromium/src/+/4f176c786029e5b60a5c579efc75... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as https://chromium.googlesource.com/chromium/src/+/4f176c786029e5b60a5c579efc75... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
