Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2914833002: [NetworkChangeNotifier] Run Windows connection type computation on safe thread (Closed)

Created:
3 years, 6 months ago by jkarlin
Modified:
3 years, 6 months ago
Reviewers:
pauljensen
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[NetworkChangeNotifier] Run Windows connection type computation on safe thread *Merge to M60* 1. Move RecomputeCurrentConnectionType to anonymous namespace 2. Call RecomputeCurrentConnectionType via callback so tests can override 3. Call RecomputeCurrentConnectionType on dns thread 4. Tests inject their own dns task runner BUG=721461, 725487 Review-Url: https://codereview.chromium.org/2893943002 Cr-Commit-Position: refs/heads/master@{#475082} (cherry picked from commit 6b0ea35f8c93c6eb229ba09624d566a339b3073b) TBR=pauljensen Review-Url: https://codereview.chromium.org/2914833002 . Cr-Commit-Position: refs/branch-heads/3112@{#59} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/6da688ab3117d09406f40fd3395c6874d0d39039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -13 lines) Patch
M net/base/network_change_notifier_win.h View 2 chunks +8 lines, -1 line 0 comments Download
M net/base/network_change_notifier_win.cc View 7 chunks +33 lines, -11 lines 0 comments Download
M net/base/network_change_notifier_win_unittest.cc View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 5 (4 generated)
jkarlin
3 years, 6 months ago (2017-05-31 17:29:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6da688ab3117d09406f40fd3395c6874d0d39039.

Powered by Google App Engine
This is Rietveld 408576698