content/renderer/render_view_impl.h - Issue 291483010: <webview>: Move name attribute to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 291483010: <webview>: Move name attribute to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newwindow_refactor

Patch Set: Addressed John's comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index 7237e9889b323262b0a0f16550d4b01b6f63633b..2e4fb14448b11804a5b49eb03b977da110ed0eef 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -700,7 +700,6 @@ class CONTENT_EXPORT RenderViewImpl

void OnShowContextMenu(const gfx::Point& location);

void OnCopyImageAt(int x, int y);

void OnSaveImageAt(int x, int y);

- void OnSetName(const std::string& name);

void OnDeterminePageLanguage();

void OnDisableScrollbarsForSmallWindows(

const gfx::Size& disable_scrollbars_size_limit);

« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »