content/renderer/render_frame_impl.cc - Issue 291483010: <webview>: Move name attribute to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 291483010: <webview>: Move name attribute to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newwindow_refactor

Patch Set: Addressed John's comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index a667a599dfde75a133593dc62e50a5e355ace9f4..a7a3245b9a8777c4814053beef8bcd636bf0ebf9 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -1566,11 +1566,7 @@ void RenderFrameImpl::didChangeName(blink::WebLocalFrame* frame,

if (!render_view_->renderer_preferences_.report_frame_name_changes)

return;

- render_view_->Send(

- new ViewHostMsg_UpdateFrameName(render_view_->GetRoutingID(),

- routing_id_,

- !frame->parent(),

- base::UTF16ToUTF8(name)));

+ FOR_EACH_OBSERVER(RenderFrameObserver, observers_, DidChangeName(name));

}

void RenderFrameImpl::didMatchCSS(

« no previous file with comments | « content/renderer/browser_plugin/browser_plugin_bindings.cc ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »