Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2914803003:
win: Explicitly disable symbols on bots using goma. (Closed)
Descriptionwin: Explicitly disable symbols on bots using goma.
With MSVC, goma implicitly disables symbols in compiler.gni. With clang,
that isn't the case, so when we enable clang by default, it currently
also implicitly enables debug info on all bots using goma. Explicitly
turn off symbols on these bots. With MSVC, that's no behavior change,
and it makes sure symbols stay off when we enable clang.
BUG=82385, 727488
Review-Url: https://codereview.chromium.org/2914803003
Cr-Commit-Position: refs/heads/master@{#476116}
Committed: https://chromium.googlesource.com/chromium/src/+/d553d8e2aaf62876c4f810b973e248d3d31f0d11
Patch Set 1 #Patch Set 2 : rename #Patch Set 3 : dedupe #Patch Set 4 : trybots too #Messages
Total messages: 23 (15 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
thakis@chromium.org changed reviewers: + dpranke@chromium.org, hans@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Can you change the "_win" to "_minimal_symbols" and create new configs if needed? I think it's better to be more obvious about what the config is doing rather than create a "$platform" config that sets stuff that might be needed on the platform. Also, I try to reserve the "$platform" names to just be `target_os = "$platform"`. lgtm if you're okay with that approach; if not feel, free to reply back :).
Done, thanks.
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2914803003/#ps20001 (title: "rename")
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2914803003/#ps40001 (title: "dedupe")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2914803003/#ps60001 (title: "trybots too")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496264330112250,
"parent_rev": "59679634e6846617095b88b22c5be83f951fedbe", "commit_rev":
"d553d8e2aaf62876c4f810b973e248d3d31f0d11"}
Message was sent while issue was closed.
Description was changed from ========== win: Explicitly disable symbols on bots using goma. With MSVC, goma implicitly disables symbols in compiler.gni. With clang, that isn't the case, so when we enable clang by default, it currently also implicitly enables debug info on all bots using goma. Explicitly turn off symbols on these bots. With MSVC, that's no behavior change, and it makes sure symbols stay off when we enable clang. BUG=82385,727488 ========== to ========== win: Explicitly disable symbols on bots using goma. With MSVC, goma implicitly disables symbols in compiler.gni. With clang, that isn't the case, so when we enable clang by default, it currently also implicitly enables debug info on all bots using goma. Explicitly turn off symbols on these bots. With MSVC, that's no behavior change, and it makes sure symbols stay off when we enable clang. BUG=82385,727488 Review-Url: https://codereview.chromium.org/2914803003 Cr-Commit-Position: refs/heads/master@{#476116} Committed: https://chromium.googlesource.com/chromium/src/+/d553d8e2aaf62876c4f810b973e2... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/d553d8e2aaf62876c4f810b973e2... |
