Copy variables.sh for all signing script targets.

Copy variables.sh for all signing script targets.

The variables.sh file was only copied for the installer tools
generation, meaning the signing scripts alone could not be built and
run. This corrects the dependency problem.

BUG=728241
Review-Url: https://codereview.chromium.org/2914783003
Cr-Commit-Position: refs/heads/master@{#476403}
Committed: https://chromium.googlesource.com/chromium/src/+/02f951db0b77eddb5c896b36f494eb7407a899ff

[Greg K, 2017-06-01 00:03:37]

Description was changed from

==========
Copy variables.sh for all signing script targets.

The variables.sh file was only copied for the installer tools
generation, meaning the signing scripts alone could not be built and
run. This corrects the dependency problem.

BUG=728241
==========

to

==========
Copy variables.sh for all signing script targets.

The variables.sh file was only copied for the installer tools
generation, meaning the signing scripts alone could not be built and
run. This corrects the dependency problem.

BUG=728241
==========

[Greg K, 2017-06-01 00:03:37]

kerrnel@chromium.org changed reviewers:
+ rsesek@chromium.org

[Greg K, 2017-06-01 00:03:50]

On 2017/06/01 00:03:37, Greg K wrote:
> mailto:kerrnel@chromium.org changed reviewers:
> + mailto:rsesek@chromium.org

Robert, since this is a GN file change, PTAL.

Thanks,

Greg

[Robert Sesek, 2017-06-01 15:08:48]

LGTM w/ a nit

https://codereview.chromium.org/2914783003/diff/1/chrome/installer/mac/BUILD.gn
File chrome/installer/mac/BUILD.gn (right):

https://codereview.chromium.org/2914783003/diff/1/chrome/installer/mac/BUILD....
chrome/installer/mac/BUILD.gn:56: copy("copy_variables") {
Add a visibility rule here:

visibility = [
  ":make_signers",
  ":copies",
]

[Greg K, 2017-06-01 17:52:28]

The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 17:52:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Greg K, 2017-06-01 18:35:14]

https://codereview.chromium.org/2914783003/diff/1/chrome/installer/mac/BUILD.gn
File chrome/installer/mac/BUILD.gn (right):

https://codereview.chromium.org/2914783003/diff/1/chrome/installer/mac/BUILD....
chrome/installer/mac/BUILD.gn:56: copy("copy_variables") {
On 2017/06/01 15:08:47, Robert Sesek wrote:
> Add a visibility rule here:
> 
> visibility = [
>   ":make_signers",
>   ":copies",
> ]

Done.

[commit-bot: I haz the power, 2017-06-01 19:41:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 19:41:22]

Dry run: This issue passed the CQ dry run.

[Greg K, 2017-06-01 20:02:44]

The CQ bit was checked by kerrnel@chromium.org

[Greg K, 2017-06-01 20:02:44]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2914783003/#ps20001
(title: "Add visibility rules")

[commit-bot: I haz the power, 2017-06-01 20:03:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 20:10:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496347364268310,
"parent_rev": "b7e58281b23c8e05b30d64503d6baa75809e4b46", "commit_rev":
"02f951db0b77eddb5c896b36f494eb7407a899ff"}

[commit-bot: I haz the power, 2017-06-01 20:10:20]

Description was changed from

==========
Copy variables.sh for all signing script targets.

The variables.sh file was only copied for the installer tools
generation, meaning the signing scripts alone could not be built and
run. This corrects the dependency problem.

BUG=728241
==========

to

==========
Copy variables.sh for all signing script targets.

The variables.sh file was only copied for the installer tools
generation, meaning the signing scripts alone could not be built and
run. This corrects the dependency problem.

BUG=728241

Review-Url: https://codereview.chromium.org/2914783003
Cr-Commit-Position: refs/heads/master@{#476403}
Committed:
https://chromium.googlesource.com/chromium/src/+/02f951db0b77eddb5c896b36f494...
==========

[commit-bot: I haz the power, 2017-06-01 20:10:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/02f951db0b77eddb5c896b36f494...