Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2914773002: Add dev console logging for file copy failure. (Closed)

Created:
3 years, 6 months ago by tetsui
Modified:
3 years, 6 months ago
Reviewers:
fukino
CC:
chromium-reviews, kouhei+script_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, hiroshige+script_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, fukino+watch_chromium.org, kochi+script_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add dev console logging for file copy failure. BUG=717442 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2914773002 Cr-Commit-Position: refs/heads/master@{#476197} Committed: https://chromium.googlesource.com/chromium/src/+/cae7e7b126db785cf7fb1ae7c6ebc558f1c2b5eb

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/file_manager/file_manager/background/js/file_operation_util.js View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
tetsui
fukino@: PTAL. Thanks!
3 years, 6 months ago (2017-06-01 02:18:58 UTC) #3
fukino
lgtm with a nit. https://codereview.chromium.org/2914773002/diff/1/ui/file_manager/file_manager/background/js/file_operation_util.js File ui/file_manager/file_manager/background/js/file_operation_util.js (right): https://codereview.chromium.org/2914773002/diff/1/ui/file_manager/file_manager/background/js/file_operation_util.js#newcode414 ui/file_manager/file_manager/background/js/file_operation_util.js:414: console.log( Let's use console.error to ...
3 years, 6 months ago (2017-06-01 03:26:03 UTC) #4
tetsui
Thank you for reviewing! https://codereview.chromium.org/2914773002/diff/1/ui/file_manager/file_manager/background/js/file_operation_util.js File ui/file_manager/file_manager/background/js/file_operation_util.js (right): https://codereview.chromium.org/2914773002/diff/1/ui/file_manager/file_manager/background/js/file_operation_util.js#newcode414 ui/file_manager/file_manager/background/js/file_operation_util.js:414: console.log( On 2017/06/01 03:26:03, fukino ...
3 years, 6 months ago (2017-06-01 04:37:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914773002/20001
3 years, 6 months ago (2017-06-01 04:37:57 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 05:04:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cae7e7b126db785cf7fb1ae7c6eb...

Powered by Google App Engine
This is Rietveld 408576698