Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2914763002: M59: Linux: Make manual libnss3 version dependency work again. (try 2) (Closed)

Created:
3 years, 6 months ago by Lei Zhang
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

M59: Linux: Make manual libnss3 version dependency work again. (try 2) When libnss3 is specified as a dependency both manually and via dpkg-shlibdeps, only the dpkg-shlibdeps dependency actually makes it into the .deb file's Depends section. To work around this, remove the entry generated by dpkg-shlibdeps, after comparing it to expectations. This used to work, but something changed during the Jessie sysroot update. BUG=691261, 726858 Review-Url: https://codereview.chromium.org/2903253005 Cr-Original-Original-Commit-Position: refs/heads/master@{#475215} Review-Url: https://codereview.chromium.org/2914763002 . Cr-Commit-Position: refs/branch-heads/3071@{#730} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/c73405cbac5a361a4129200066007e1fde882484

Patch Set 1 : First attempt #

Patch Set 2 : Fix missing space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M chrome/installer/linux/debian/build.sh View 1 3 chunks +24 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Lei Zhang
3 years, 6 months ago (2017-05-31 08:11:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c73405cbac5a361a4129200066007e1fde882484.

Powered by Google App Engine
This is Rietveld 408576698