Refactor TouchEventManager::TouchInfo class

Refactor TouchEventManager::TouchInfo class

Remove redundant fields from TouchInfo class
as well as moving away from handling groups
of touchpoints in different functions in
TouchEventManager.

BUG=727845
Review-Url: https://codereview.chromium.org/2914673002
Cr-Commit-Position: refs/heads/master@{#476636}
Committed: https://chromium.googlesource.com/chromium/src/+/c6a12bec800b31a540b910f6c533ced0d2ea98a4

[Navid Zolghadr, 2017-05-30 20:54:05]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 20:54:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2017-05-30 21:00:52]

nzolghadr@chromium.org changed reviewers:
+ dtapuska@chromium.org, mustaq@chromium.org

[Navid Zolghadr, 2017-05-30 21:00:53]

I realized before I can create WebPointerEvent it is better to do this clean
first.

[commit-bot: I haz the power, 2017-05-30 22:23:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 22:23:18]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Navid Zolghadr, 2017-05-31 16:05:59]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 16:06:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 17:44:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 17:44:07]

Dry run: This issue passed the CQ dry run.

[mustaq, 2017-05-31 18:22:45]

Thanks for the well-thought cleanup! LGTM % a few nits.

https://codereview.chromium.org/2914673002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/PointerEventManager.h (right):

https://codereview.chromium.org/2914673002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/PointerEventManager.h:144: // Generate
PointerEventTarget for a WebTouchPoint, hit-testing as necessary.
Nit: "Returns..."

https://codereview.chromium.org/2914673002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/TouchEventManager.cpp (right):

https://codereview.chromium.org/2914673002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/TouchEventManager.cpp:374: void
TouchEventManager::UpdateTargetAndRegionMapsForTouchStarts(
Since this now handles a single touch point, you can make is a bit cleaner:
- Move |state == kStatePressed| comparison to caller
- Add a dcheck here instead
- Function name s/ForTouchStarts/ForTouchStart/.

https://codereview.chromium.org/2914673002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/TouchEventManager.h (right):

https://codereview.chromium.org/2914673002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/TouchEventManager.h:35: WebInputEventResult
HandleTouchEvent(
We missed this before: please clarify that the PointerEventTarget entries
correspond to the touch points in the TouchEvent, in the same order.  This is to
avoid confusion with the 3 lists in params (2 vectors params + TouchPoints).

https://codereview.chromium.org/2914673002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/TouchEventManager.h:56: bool
ReHitTestTouchPointsIfNeeded(
Nit: Drop "Re" from the name and "again" from the comment.

[Navid Zolghadr, 2017-06-01 17:57:26]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 17:57:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2017-06-01 17:57:51]

ptal.

https://codereview.chromium.org/2914673002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/PointerEventManager.h (right):

https://codereview.chromium.org/2914673002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/PointerEventManager.h:144: // Generate
PointerEventTarget for a WebTouchPoint, hit-testing as necessary.
On 2017/05/31 18:22:44, mustaq wrote:
> Nit: "Returns..."

Done.

https://codereview.chromium.org/2914673002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/TouchEventManager.cpp (right):

https://codereview.chromium.org/2914673002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/TouchEventManager.cpp:374: void
TouchEventManager::UpdateTargetAndRegionMapsForTouchStarts(
On 2017/05/31 18:22:44, mustaq wrote:
> Since this now handles a single touch point, you can make is a bit cleaner:
> - Move |state == kStatePressed| comparison to caller
> - Add a dcheck here instead
> - Function name s/ForTouchStarts/ForTouchStart/.

Done.

https://codereview.chromium.org/2914673002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/TouchEventManager.h (right):

https://codereview.chromium.org/2914673002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/TouchEventManager.h:35: WebInputEventResult
HandleTouchEvent(
On 2017/05/31 18:22:45, mustaq wrote:
> We missed this before: please clarify that the PointerEventTarget entries
> correspond to the touch points in the TouchEvent, in the same order.  This is
to
> avoid confusion with the 3 lists in params (2 vectors params + TouchPoints).

Done.

https://codereview.chromium.org/2914673002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/TouchEventManager.h:56: bool
ReHitTestTouchPointsIfNeeded(
On 2017/05/31 18:22:45, mustaq wrote:
> Nit: Drop "Re" from the name and "again" from the comment.

Done.

[commit-bot: I haz the power, 2017-06-01 18:01:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 18:01:12]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mustaq, 2017-06-01 18:10:18]

Still LGTM.

[dtapuska, 2017-06-01 18:53:48]

On 2017/06/01 18:10:18, mustaq wrote:
> Still LGTM.

lgtm

[Navid Zolghadr, 2017-06-01 20:33:36]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 20:34:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 00:43:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 00:43:51]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Navid Zolghadr, 2017-06-02 14:27:55]

The CQ bit was checked by nzolghadr@chromium.org

[Navid Zolghadr, 2017-06-02 14:27:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org, mustaq@chromium.org
Link to the patchset: https://codereview.chromium.org/2914673002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-02 14:28:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 14:34:08]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496413675747370,
"parent_rev": "6f5b3053ff11488b985c18e8d03472356e049fd5", "commit_rev":
"c6a12bec800b31a540b910f6c533ced0d2ea98a4"}

[commit-bot: I haz the power, 2017-06-02 14:34:24]

Description was changed from

==========
Refactor TouchEventManager::TouchInfo class

Remove redundant fields from TouchInfo class
as well as moving away from handling groups
of touchpoints in different functions in
TouchEventManager.

BUG=727845
==========

to

==========
Refactor TouchEventManager::TouchInfo class

Remove redundant fields from TouchInfo class
as well as moving away from handling groups
of touchpoints in different functions in
TouchEventManager.

BUG=727845

Review-Url: https://codereview.chromium.org/2914673002
Cr-Commit-Position: refs/heads/master@{#476636}
Committed:
https://chromium.googlesource.com/chromium/src/+/c6a12bec800b31a540b910f6c533...
==========

[commit-bot: I haz the power, 2017-06-02 14:34:25]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c6a12bec800b31a540b910f6c533...