|
|
Created:
3 years, 6 months ago by Tom Anderson Modified:
3 years, 6 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll buildtools to 31d4da
This CL rolls in the following changes:
https://chromium.googlesource.com/chromium/buildtools/+/3b8de5198d784fe2b7cc9f75dcf2ca8eb616a81e..31d4daad5d9af672d4e234570a24f3fd844bb713
The last reference to //build/config/compiler:pthread is removed, so
this CL also removes the config.
R=thakis@chromium.org,brettw@chromium.org
BUG=593874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
Review-Url: https://codereview.chromium.org/2914653002
Cr-Commit-Position: refs/heads/master@{#476586}
Committed: https://chromium.googlesource.com/chromium/src/+/e8b52c26834fbeba662c6cf0073d88aefb7907a8
Patch Set 1 #Patch Set 2 : Update buildtools revision to latest version #Patch Set 3 : Update buildtools again #
Total comments: 1
Messages
Total messages: 64 (55 generated)
Description was changed from ========== Statically link libc++ on non-component builds BUG=593874 ========== to ========== Statically link libc++ on non-component builds BUG=593874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng ==========
Description was changed from ========== Statically link libc++ on non-component builds BUG=593874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng ========== to ========== Statically link libc++ on non-component builds BUG=593874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng ==========
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: CQ cannot get SignCLA result. Please try later.
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Statically link libc++ on non-component builds BUG=593874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng ========== to ========== Statically link libc++ on non-component builds R=thakis@chromium.org BUG=593874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng;tryserver.chromium.mac:mac_chromium_asan_rel_ng ==========
thomasanderson@chromium.org changed reviewers: + thakis@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Statically link libc++ on non-component builds R=thakis@chromium.org BUG=593874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng;tryserver.chromium.mac:mac_chromium_asan_rel_ng ========== to ========== Statically link libc++ on non-component builds R=thakis@chromium.org BUG=593874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng ==========
Description was changed from ========== Statically link libc++ on non-component builds R=thakis@chromium.org BUG=593874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng ========== to ========== Statically link libc++ on non-component builds R=thakis@chromium.org,brettw@chromium.org BUG=593874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng ==========
thomasanderson@chromium.org changed reviewers: + brettw@chromium.org
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_asan_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_asan...)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_asan_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_asan...)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Statically link libc++ on non-component builds R=thakis@chromium.org,brettw@chromium.org BUG=593874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng ========== to ========== Roll buildtools to 31d4da This CL rolls in the following changes: https://chromium.googlesource.com/chromium/buildtools/+/3b8de5198d784fe2b7cc9... The last reference to //build/config/compiler:pthread is removed, so this CL also removes the config. R=thakis@chromium.org,brettw@chromium.org BUG=593874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng ==========
Nico and Brett ptal
Brett and Nico ptal
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Lgtm I had expected more things would keep the pthread config alive. But happy to see that that's not the case :-) https://codereview.chromium.org/2914653002/diff/120001/build/config/compiler/... File build/config/compiler/BUILD.gn (left): https://codereview.chromium.org/2914653002/diff/120001/build/config/compiler/... build/config/compiler/BUILD.gn:550: # configs -= [ "//build/config/compiler:pthread" ] Huh, I'm surprised nobody seems to do this.
lgtm
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 120001, "attempt_start_ts": 1496382066968390, "parent_rev": "359a15605f7907df8909b75dfac49dfd5d98f6ae", "commit_rev": "e8b52c26834fbeba662c6cf0073d88aefb7907a8"}
Message was sent while issue was closed.
Description was changed from ========== Roll buildtools to 31d4da This CL rolls in the following changes: https://chromium.googlesource.com/chromium/buildtools/+/3b8de5198d784fe2b7cc9... The last reference to //build/config/compiler:pthread is removed, so this CL also removes the config. R=thakis@chromium.org,brettw@chromium.org BUG=593874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng ========== to ========== Roll buildtools to 31d4da This CL rolls in the following changes: https://chromium.googlesource.com/chromium/buildtools/+/3b8de5198d784fe2b7cc9... The last reference to //build/config/compiler:pthread is removed, so this CL also removes the config. R=thakis@chromium.org,brettw@chromium.org BUG=593874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng Review-Url: https://codereview.chromium.org/2914653002 Cr-Commit-Position: refs/heads/master@{#476586} Committed: https://chromium.googlesource.com/chromium/src/+/e8b52c26834fbeba662c6cf0073d... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:120001) as https://chromium.googlesource.com/chromium/src/+/e8b52c26834fbeba662c6cf0073d...
Message was sent while issue was closed.
On 2017/06/02 05:46:19, commit-bot: I haz the power wrote: > Committed patchset #3 (id:120001) as > https://chromium.googlesource.com/chromium/src/+/e8b52c26834fbeba662c6cf0073d... Hi, this change broke build of sel_ldr in asan configuration. With is_asan = true is_debug = false in gn args, run ninja sel_ldr. ../../native_client/src/trusted/service_runtime/linux/thread_suspension.c:272: error: undefined reference to 'pthread_kill' ../../native_client/src/shared/platform/posix/nacl_host_desc.c:177: error: undefined reference to 'pthread_once' ../../native_client/src/shared/platform/posix/nacl_host_desc.c:177: error: undefined reference to 'pthread_once' ../../native_client/src/shared/platform/posix/nacl_threads.c:56: error: undefined reference to 'pthread_attr_setstacksize' /code/chromium/src/third_party/llvm-build/Release+Asserts/lib/clang/5.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_linux.cc.o):function __asan::AsanDlSymNext(char const*): error: undefined reference to 'dlsym' [...]
Message was sent while issue was closed.
On 2017/06/05 19:44:29, eugenis wrote: > On 2017/06/02 05:46:19, commit-bot: I haz the power wrote: > > Committed patchset #3 (id:120001) as > > > https://chromium.googlesource.com/chromium/src/+/e8b52c26834fbeba662c6cf0073d... > > Hi, > > this change broke build of sel_ldr in asan configuration. > > With > is_asan = true > is_debug = false > in gn args, run > ninja sel_ldr. > > ../../native_client/src/trusted/service_runtime/linux/thread_suspension.c:272: > error: undefined reference to 'pthread_kill' > ../../native_client/src/shared/platform/posix/nacl_host_desc.c:177: error: > undefined reference to 'pthread_once' > ../../native_client/src/shared/platform/posix/nacl_host_desc.c:177: error: > undefined reference to 'pthread_once' > ../../native_client/src/shared/platform/posix/nacl_threads.c:56: error: > undefined reference to 'pthread_attr_setstacksize' > /code/chromium/src/third_party/llvm-build/Release+Asserts/lib/clang/5.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_linux.cc.o):function > __asan::AsanDlSymNext(char const*): error: undefined reference to 'dlsym' > [...] https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/7412
Message was sent while issue was closed.
On 2017/06/05 19:45:26, eugenis wrote: > On 2017/06/05 19:44:29, eugenis wrote: > > On 2017/06/02 05:46:19, commit-bot: I haz the power wrote: > > > Committed patchset #3 (id:120001) as > > > > > > https://chromium.googlesource.com/chromium/src/+/e8b52c26834fbeba662c6cf0073d... > > > > Hi, > > > > this change broke build of sel_ldr in asan configuration. > > > > With > > is_asan = true > > is_debug = false > > in gn args, run > > ninja sel_ldr. > > > > ../../native_client/src/trusted/service_runtime/linux/thread_suspension.c:272: > > error: undefined reference to 'pthread_kill' > > ../../native_client/src/shared/platform/posix/nacl_host_desc.c:177: error: > > undefined reference to 'pthread_once' > > ../../native_client/src/shared/platform/posix/nacl_host_desc.c:177: error: > > undefined reference to 'pthread_once' > > ../../native_client/src/shared/platform/posix/nacl_threads.c:56: error: > > undefined reference to 'pthread_attr_setstacksize' > > > /code/chromium/src/third_party/llvm-build/Release+Asserts/lib/clang/5.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_linux.cc.o):function > > __asan::AsanDlSymNext(char const*): error: undefined reference to 'dlsym' > > [...] > > https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/7412 Fix for that: https://chromium-review.googlesource.com/c/518463/ |