Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2914643003: VS 2015 Update 3 with 10.0.15063.0 sdk (Closed)

Created:
3 years, 6 months ago by brucedawson
Modified:
3 years, 6 months ago
Reviewers:
hubbe, scottmg
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VS 2015 Update 3 with 10.0.15063.0 SDK This change switches the VS 2015 package to use the 10.0.15063.0 SDK. This is necessary for crrev.com/2938543002. As a side-effect of the repackaging it also upgrades the compiler from 19.00.24213.1 to 19.00.24215.1. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. The process for creating this package is: - Install depot tools, run ‘gclient’, and add depot_tools to the path - Install final version of VS 2015 Professional Update 3 with these options: * Visual C++ and make sure the three nodes underneath are also selected * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected Then the Windows 10.0.15063.0 SDK was installed. This also installs the x86 and x64 debuggers. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-is-broken-bitsh-indirectly-references-no.html The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 Finally the packaging script (updated in https://chromium-review.googlesource.com/c/519982) was run: python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0 This CL does *not* change build\toolchain\win\setup_toolchain.py to request the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is because this SDK is not yet required (crrev.com/2938543002 is a benign NOP with the 14393 SDK) and because wrl\event.h is still broken (for clang-cl) in the latest 15063 SDK. BUG=682416 Review-Url: https://codereview.chromium.org/2914643003 Cr-Commit-Position: refs/heads/master@{#479900} Committed: https://chromium.googlesource.com/chromium/src/+/407583a866bb1839b09289b5f2e856b15700ea51

Patch Set 1 #

Patch Set 2 : Patched event.h for clang-cl #

Patch Set 3 : Don't force developers to use Creators Update SDK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/vs_toolchain.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 32 (28 generated)
brucedawson
hubbe@ needs this in order to detect HDR displays. The broken nature of the 15063 ...
3 years, 6 months ago (2017-06-16 00:05:00 UTC) #26
scottmg
lgtm
3 years, 6 months ago (2017-06-16 00:27:51 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914643003/40001
3 years, 6 months ago (2017-06-16 00:40:24 UTC) #29
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 01:50:38 UTC) #32
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/407583a866bb1839b09289b5f2e8...

Powered by Google App Engine
This is Rietveld 408576698