|
|
Created:
3 years, 6 months ago by brucedawson Modified:
3 years, 6 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionVS 2015 Update 3 with 10.0.15063.0 SDK
This change switches the VS 2015 package to use the 10.0.15063.0 SDK.
This is necessary for crrev.com/2938543002. As a side-effect of the
repackaging it also upgrades the compiler from 19.00.24213.1 to
19.00.24215.1.
Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.
The process for creating this package is:
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install final version of VS 2015 Professional Update 3 with these options:
* Visual C++ and make sure the three nodes underneath are also selected
* Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected
Then the Windows 10.0.15063.0 SDK was installed. This also installs
the x86 and x64 debuggers.
Then wrl\event.h was patched to work around a problem with clang-cl
builds, as described towards the end of this bug:
https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-is-broken-bitsh-indirectly-references-no.html
The patched version of event.h is attached to this bug comment:
https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120
Finally the packaging script (updated in
https://chromium-review.googlesource.com/c/519982) was run:
python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0
This CL does *not* change build\toolchain\win\setup_toolchain.py to request
the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is
because this SDK is not yet required (crrev.com/2938543002 is a benign NOP
with the 14393 SDK) and because wrl\event.h is still broken (for clang-cl)
in the latest 15063 SDK.
BUG=682416
Review-Url: https://codereview.chromium.org/2914643003
Cr-Commit-Position: refs/heads/master@{#479900}
Committed: https://chromium.googlesource.com/chromium/src/+/407583a866bb1839b09289b5f2e856b15700ea51
Patch Set 1 #Patch Set 2 : Patched event.h for clang-cl #Patch Set 3 : Don't force developers to use Creators Update SDK #Messages
Total messages: 32 (28 generated)
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== VS 2015 Update 3 with 10.0.15063.0 sdk ========== to ========== VS 2015 Update 3 with 10.0.15063.0 SDK ==========
Description was changed from ========== VS 2015 Update 3 with 10.0.15063.0 SDK ========== to ========== VS 2015 Update 3 with 10.0.15063.0 SDK This change switches the VS 2015 package to use the 10.0.15063.0 SDK. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. The process for creating this package is: - Install depot tools, run ‘gclient’, and add depot_tools to the path - Install final version of VS 2015 Professional Update 3 * Visual C++ and make sure the three nodes underneath are also selected * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected * Install the Windows 10.0.15086.0 SDK, patched sometime in May Then the Windows 10.0.15063.0 SDK was installed. This is necessary because of missing header files in the version packaged with VS 2017, and this also installs the x86 and x64 debuggers. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 Finally the packaging script (updated in https://chromium-review.googlesource.com/c/519982) was run: python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0 With this change the 10.0.15063.0 SDK will be required. If building with the installed toolchain then you must update the SDK to work around a bug when including Bits.h. If building with clang-cl then you must patch wrl\event.h as described above. R=scottmg@chromium.org BUG=682416 ==========
Description was changed from ========== VS 2015 Update 3 with 10.0.15063.0 SDK This change switches the VS 2015 package to use the 10.0.15063.0 SDK. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. The process for creating this package is: - Install depot tools, run ‘gclient’, and add depot_tools to the path - Install final version of VS 2015 Professional Update 3 * Visual C++ and make sure the three nodes underneath are also selected * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected * Install the Windows 10.0.15086.0 SDK, patched sometime in May Then the Windows 10.0.15063.0 SDK was installed. This is necessary because of missing header files in the version packaged with VS 2017, and this also installs the x86 and x64 debuggers. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 Finally the packaging script (updated in https://chromium-review.googlesource.com/c/519982) was run: python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0 With this change the 10.0.15063.0 SDK will be required. If building with the installed toolchain then you must update the SDK to work around a bug when including Bits.h. If building with clang-cl then you must patch wrl\event.h as described above. R=scottmg@chromium.org BUG=682416 ========== to ========== VS 2015 Update 3 with 10.0.15063.0 SDK This change switches the VS 2015 package to use the 10.0.15063.0 SDK. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. The process for creating this package is: - Install depot tools, run ‘gclient’, and add depot_tools to the path - Install final version of VS 2015 Professional Update 3 * Visual C++ and make sure the three nodes underneath are also selected * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected Then the Windows 10.0.15063.0 SDK was installed. This also installs the x86 and x64 debuggers. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 Finally the packaging script (updated in https://chromium-review.googlesource.com/c/519982) was run: python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0 In addition to updating the package this also updates Chrome's build to require the 10.0.15063.0 SDK. If building with the installed toolchain instead of the packaged toolchain then you must update the SDK to work around a bug when including Bits.h. If building with clang-cl then you must also patch wrl\event.h as described above. R=scottmg@chromium.org BUG=682416 ==========
brucedawson@chromium.org changed reviewers: + hubbe@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== VS 2015 Update 3 with 10.0.15063.0 SDK This change switches the VS 2015 package to use the 10.0.15063.0 SDK. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. The process for creating this package is: - Install depot tools, run ‘gclient’, and add depot_tools to the path - Install final version of VS 2015 Professional Update 3 * Visual C++ and make sure the three nodes underneath are also selected * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected Then the Windows 10.0.15063.0 SDK was installed. This also installs the x86 and x64 debuggers. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 Finally the packaging script (updated in https://chromium-review.googlesource.com/c/519982) was run: python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0 In addition to updating the package this also updates Chrome's build to require the 10.0.15063.0 SDK. If building with the installed toolchain instead of the packaged toolchain then you must update the SDK to work around a bug when including Bits.h. If building with clang-cl then you must also patch wrl\event.h as described above. R=scottmg@chromium.org BUG=682416 ========== to ========== VS 2015 Update 3 with 10.0.15063.0 SDK This change switches the VS 2015 package to use the 10.0.15063.0 SDK. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. The process for creating this package is: - Install depot tools, run ‘gclient’, and add depot_tools to the path - Install final version of VS 2015 Professional Update 3 with these options: * Visual C++ and make sure the three nodes underneath are also selected * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected Then the Windows 10.0.15063.0 SDK was installed. This also installs the x86 and x64 debuggers. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 Finally the packaging script (updated in https://chromium-review.googlesource.com/c/519982) was run: python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0 In addition to updating the package this also updates Chrome's build to require the 10.0.15063.0 SDK. If building with the installed toolchain instead of the packaged toolchain then you must update the SDK to work around a bug when including Bits.h. If building with clang-cl then you must also patch wrl\event.h as described above. R=scottmg@chromium.org BUG=682416 ==========
Description was changed from ========== VS 2015 Update 3 with 10.0.15063.0 SDK This change switches the VS 2015 package to use the 10.0.15063.0 SDK. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. The process for creating this package is: - Install depot tools, run ‘gclient’, and add depot_tools to the path - Install final version of VS 2015 Professional Update 3 with these options: * Visual C++ and make sure the three nodes underneath are also selected * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected Then the Windows 10.0.15063.0 SDK was installed. This also installs the x86 and x64 debuggers. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 Finally the packaging script (updated in https://chromium-review.googlesource.com/c/519982) was run: python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0 In addition to updating the package this also updates Chrome's build to require the 10.0.15063.0 SDK. If building with the installed toolchain instead of the packaged toolchain then you must update the SDK to work around a bug when including Bits.h. If building with clang-cl then you must also patch wrl\event.h as described above. R=scottmg@chromium.org BUG=682416 ========== to ========== VS 2015 Update 3 with 10.0.15063.0 SDK This change switches the VS 2015 package to use the 10.0.15063.0 SDK. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. The process for creating this package is: - Install depot tools, run ‘gclient’, and add depot_tools to the path - Install final version of VS 2015 Professional Update 3 with these options: * Visual C++ and make sure the three nodes underneath are also selected * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected Then the Windows 10.0.15063.0 SDK was installed. This also installs the x86 and x64 debuggers. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 Finally the packaging script (updated in https://chromium-review.googlesource.com/c/519982) was run: python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0 This CL does *not* change build\toolchain\win\setup_toolchain.py to request the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is because this SDK is not yet required (crrev.com/2938543002 is a benign NOP with the 14393 SDK) and because wrl\event.h is still broken (for clang-cl) in the latest 15063 SDK. BUG=682416 ==========
brucedawson@chromium.org changed reviewers: + scottmg@chromium.org
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== VS 2015 Update 3 with 10.0.15063.0 SDK This change switches the VS 2015 package to use the 10.0.15063.0 SDK. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. The process for creating this package is: - Install depot tools, run ‘gclient’, and add depot_tools to the path - Install final version of VS 2015 Professional Update 3 with these options: * Visual C++ and make sure the three nodes underneath are also selected * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected Then the Windows 10.0.15063.0 SDK was installed. This also installs the x86 and x64 debuggers. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 Finally the packaging script (updated in https://chromium-review.googlesource.com/c/519982) was run: python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0 This CL does *not* change build\toolchain\win\setup_toolchain.py to request the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is because this SDK is not yet required (crrev.com/2938543002 is a benign NOP with the 14393 SDK) and because wrl\event.h is still broken (for clang-cl) in the latest 15063 SDK. BUG=682416 ========== to ========== VS 2015 Update 3 with 10.0.15063.0 SDK This change switches the VS 2015 package to use the 10.0.15063.0 SDK. This is necessary for crrev.com/2938543002. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. The process for creating this package is: - Install depot tools, run ‘gclient’, and add depot_tools to the path - Install final version of VS 2015 Professional Update 3 with these options: * Visual C++ and make sure the three nodes underneath are also selected * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected Then the Windows 10.0.15063.0 SDK was installed. This also installs the x86 and x64 debuggers. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 Finally the packaging script (updated in https://chromium-review.googlesource.com/c/519982) was run: python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0 This CL does *not* change build\toolchain\win\setup_toolchain.py to request the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is because this SDK is not yet required (crrev.com/2938543002 is a benign NOP with the 14393 SDK) and because wrl\event.h is still broken (for clang-cl) in the latest 15063 SDK. BUG=682416 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== VS 2015 Update 3 with 10.0.15063.0 SDK This change switches the VS 2015 package to use the 10.0.15063.0 SDK. This is necessary for crrev.com/2938543002. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. The process for creating this package is: - Install depot tools, run ‘gclient’, and add depot_tools to the path - Install final version of VS 2015 Professional Update 3 with these options: * Visual C++ and make sure the three nodes underneath are also selected * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected Then the Windows 10.0.15063.0 SDK was installed. This also installs the x86 and x64 debuggers. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 Finally the packaging script (updated in https://chromium-review.googlesource.com/c/519982) was run: python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0 This CL does *not* change build\toolchain\win\setup_toolchain.py to request the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is because this SDK is not yet required (crrev.com/2938543002 is a benign NOP with the 14393 SDK) and because wrl\event.h is still broken (for clang-cl) in the latest 15063 SDK. BUG=682416 ========== to ========== VS 2015 Update 3 with 10.0.15063.0 SDK This change switches the VS 2015 package to use the 10.0.15063.0 SDK. This is necessary for crrev.com/2938543002. As a side-effect of the repackaging it also upgrades the compiler from 19.00.24213.1 to 19.00.24215.1. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. The process for creating this package is: - Install depot tools, run ‘gclient’, and add depot_tools to the path - Install final version of VS 2015 Professional Update 3 with these options: * Visual C++ and make sure the three nodes underneath are also selected * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected Then the Windows 10.0.15063.0 SDK was installed. This also installs the x86 and x64 debuggers. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 Finally the packaging script (updated in https://chromium-review.googlesource.com/c/519982) was run: python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0 This CL does *not* change build\toolchain\win\setup_toolchain.py to request the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is because this SDK is not yet required (crrev.com/2938543002 is a benign NOP with the 14393 SDK) and because wrl\event.h is still broken (for clang-cl) in the latest 15063 SDK. BUG=682416 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
hubbe@ needs this in order to detect HDR displays. The broken nature of the 15063 SDK makes this a delicate dance, but I think this should work smoothly. PTAL. Note the small compiler change which this also triggers.
lgtm
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497573606197510, "parent_rev": "e7b173d3f09519dccd5cd6fbc1d55bd300a895ae", "commit_rev": "407583a866bb1839b09289b5f2e856b15700ea51"}
Message was sent while issue was closed.
Description was changed from ========== VS 2015 Update 3 with 10.0.15063.0 SDK This change switches the VS 2015 package to use the 10.0.15063.0 SDK. This is necessary for crrev.com/2938543002. As a side-effect of the repackaging it also upgrades the compiler from 19.00.24213.1 to 19.00.24215.1. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. The process for creating this package is: - Install depot tools, run ‘gclient’, and add depot_tools to the path - Install final version of VS 2015 Professional Update 3 with these options: * Visual C++ and make sure the three nodes underneath are also selected * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected Then the Windows 10.0.15063.0 SDK was installed. This also installs the x86 and x64 debuggers. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 Finally the packaging script (updated in https://chromium-review.googlesource.com/c/519982) was run: python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0 This CL does *not* change build\toolchain\win\setup_toolchain.py to request the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is because this SDK is not yet required (crrev.com/2938543002 is a benign NOP with the 14393 SDK) and because wrl\event.h is still broken (for clang-cl) in the latest 15063 SDK. BUG=682416 ========== to ========== VS 2015 Update 3 with 10.0.15063.0 SDK This change switches the VS 2015 package to use the 10.0.15063.0 SDK. This is necessary for crrev.com/2938543002. As a side-effect of the repackaging it also upgrades the compiler from 19.00.24213.1 to 19.00.24215.1. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. The process for creating this package is: - Install depot tools, run ‘gclient’, and add depot_tools to the path - Install final version of VS 2015 Professional Update 3 with these options: * Visual C++ and make sure the three nodes underneath are also selected * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected Then the Windows 10.0.15063.0 SDK was installed. This also installs the x86 and x64 debuggers. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 Finally the packaging script (updated in https://chromium-review.googlesource.com/c/519982) was run: python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0 This CL does *not* change build\toolchain\win\setup_toolchain.py to request the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is because this SDK is not yet required (crrev.com/2938543002 is a benign NOP with the 14393 SDK) and because wrl\event.h is still broken (for clang-cl) in the latest 15063 SDK. BUG=682416 Review-Url: https://codereview.chromium.org/2914643003 Cr-Commit-Position: refs/heads/master@{#479900} Committed: https://chromium.googlesource.com/chromium/src/+/407583a866bb1839b09289b5f2e8... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/407583a866bb1839b09289b5f2e8... |