Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2914583003: Add null checks of GetImageObserver() in BitmapImage (Closed)

Created:
3 years, 6 months ago by hiroshige
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Add null checks of GetImageObserver() in BitmapImage Because GetImageObserver() can be null but some callsites have used it without null checks. This CL adds null checks to BitmapImage, while [1] adds to SVG-related classes. [1] https://codereview.chromium.org/2905833003/ BUG=726220 Review-Url: https://codereview.chromium.org/2906583003 Cr-Original-Commit-Position: refs/heads/master@{#475147} Review-Url: https://codereview.chromium.org/2914583003 . Cr-Commit-Position: refs/branch-heads/3112@{#25} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/bb2694f0cbf46f6ac6b467bf04a9373e4981c2ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/WebKit/Source/platform/graphics/BitmapImage.cpp View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
hiroshige
3 years, 6 months ago (2017-05-30 09:34:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bb2694f0cbf46f6ac6b467bf04a9373e4981c2ba.

Powered by Google App Engine
This is Rietveld 408576698