Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2914543002: [vr] Bail on unhandled code points. (Closed)

Created:
3 years, 6 months ago by cjgrant
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[vr] Bail on unhandled code points. When we encounter a URL with glyphs we cannot render we now exit VR mode. This CL also establishes an "unsupported mode" enumeration and corresponding metrics. BUG=722861 Review-Url: https://codereview.chromium.org/2902393002 Cr-Original-Commit-Position: refs/heads/master@{#475222} Review-Url: https://codereview.chromium.org/2914543002 . Cr-Commit-Position: refs/branch-heads/3112@{#17} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/86a8661f2efe60271e9311d0cb9f03ecd8499940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -40 lines) Patch
M chrome/browser/android/vr_shell/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/font_fallback.h View 1 chunk +13 lines, -5 lines 0 comments Download
M chrome/browser/android/vr_shell/font_fallback.cc View 3 chunks +19 lines, -12 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/exit_warning_texture.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/textures/system_indicator_texture.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/textures/ui_texture.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/textures/ui_texture.cc View 2 chunks +19 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture.h View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc View 4 chunks +63 lines, -5 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/url_bar.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/url_bar.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/android/vr_shell/ui_unsupported_mode.h View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_browser_interface.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_thread.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 1 chunk +3 lines, -1 line 0 comments Download
M tools/metrics/histograms/enums.xml View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
cjgrant
3 years, 6 months ago (2017-05-29 18:59:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
86a8661f2efe60271e9311d0cb9f03ecd8499940.

Powered by Google App Engine
This is Rietveld 408576698