Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2914523002:
[LayoutNG] Fix not to add borders/paddings to every line (Closed)
|
Created:
3 years, 6 months ago by kojii Modified:
3 years, 6 months ago CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, lchoi+reviews_chromium.org, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[LayoutNG] Fix not to add borders/paddings to every line
The initial CL to support borders/paddings of the containing block of
inlines[1] added the block start of borders/paddings to every line.
This patch fixes to add it only once, to the content_size_, the same way
as NGBlockLayoutAlgorithm does.
[1] https://codereview.chromium.org/2886453005
BUG=636993, 725359
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Review-Url: https://codereview.chromium.org/2914523002
Cr-Commit-Position: refs/heads/master@{#475810}
Committed: https://chromium.googlesource.com/chromium/src/+/bfb708ff0dc28bafad16a2833b16823e7efb09f1
Patch Set 1 #Patch Set 2 : Fix #
Messages
Total messages: 21 (15 generated)
Description was changed from ========== ngpb BUG= ========== to ========== ngpb BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== ngpb BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ========== to ========== [LayoutNG] Fix not to add borders/paddings to each line The initial CL to support borders/paddings of the containing block of inlines[1] added the block start of borders/paddings to every line. This patch fixes to add it only once, to the content_size_, the same way as NGBlockLayoutAlgorithm does. [1] https://codereview.chromium.org/2886453005 BUG=636993, 725359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
kojii@chromium.org changed reviewers: + glebl@chromium.org, ikilpatrick@chromium.org
PTAL.
Description was changed from ========== [LayoutNG] Fix not to add borders/paddings to each line The initial CL to support borders/paddings of the containing block of inlines[1] added the block start of borders/paddings to every line. This patch fixes to add it only once, to the content_size_, the same way as NGBlockLayoutAlgorithm does. [1] https://codereview.chromium.org/2886453005 BUG=636993, 725359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ========== to ========== [LayoutNG] Fix not to add borders/paddings to every line The initial CL to support borders/paddings of the containing block of inlines[1] added the block start of borders/paddings to every line. This patch fixes to add it only once, to the content_size_, the same way as NGBlockLayoutAlgorithm does. [1] https://codereview.chromium.org/2886453005 BUG=636993, 725359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
lgtm
The CQ bit was checked by kojii@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kojii@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496199693320500,
"parent_rev": "4223216d2fa2a111c5e0636017bb6766682adda9", "commit_rev":
"bfb708ff0dc28bafad16a2833b16823e7efb09f1"}
Message was sent while issue was closed.
Description was changed from ========== [LayoutNG] Fix not to add borders/paddings to every line The initial CL to support borders/paddings of the containing block of inlines[1] added the block start of borders/paddings to every line. This patch fixes to add it only once, to the content_size_, the same way as NGBlockLayoutAlgorithm does. [1] https://codereview.chromium.org/2886453005 BUG=636993, 725359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ========== to ========== [LayoutNG] Fix not to add borders/paddings to every line The initial CL to support borders/paddings of the containing block of inlines[1] added the block start of borders/paddings to every line. This patch fixes to add it only once, to the content_size_, the same way as NGBlockLayoutAlgorithm does. [1] https://codereview.chromium.org/2886453005 BUG=636993, 725359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2914523002 Cr-Commit-Position: refs/heads/master@{#475810} Committed: https://chromium.googlesource.com/chromium/src/+/bfb708ff0dc28bafad16a2833b16... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/bfb708ff0dc28bafad16a2833b16... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
