Use explicit dividers between preferences in AccountManagementFragment

Use explicit dividers between preferences in AccountManagementFragment

This CL replaces dividers provided by ListView with explicit ones.
ListView always draws divider after every selectable preference, but in
AccountManagementFragment there are cases when it is necessary to show divider
after non-selectable preference and hide divider after selectable ones.
This CL achieves such a fine-grained control by setting ListView divider to
null and adding explicit dividers where necessary.

BUG=722907
Review-Url: https://codereview.chromium.org/2914513002
Cr-Commit-Position: refs/heads/master@{#475902}
Committed: https://chromium.googlesource.com/chromium/src/+/93fdbfecc3703f4b1459d8dec0fb412ed508f90a

[bsazonov, 2017-05-29 15:03:46]

bsazonov@chromium.org changed reviewers:
+ bauerb@chromium.org

[bsazonov, 2017-05-29 15:03:47]

Bernhard, please take a look.

[bsazonov, 2017-05-29 15:04:01]

The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 15:04:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 15:49:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 15:49:20]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-05-31 13:13:50]

lgtm

https://codereview.chromium.org/2914513002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java
(right):

https://codereview.chromium.org/2914513002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java:156:
View rootView = getView();
Just inline this variable.

[bsazonov, 2017-05-31 13:23:51]

Thanks!

https://codereview.chromium.org/2914513002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java
(right):

https://codereview.chromium.org/2914513002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java:156:
View rootView = getView();
On 2017/05/31 13:13:50, Bernhard Bauer wrote:
> Just inline this variable.

Done.

[bsazonov, 2017-05-31 13:24:07]

The CQ bit was checked by bsazonov@chromium.org

[bsazonov, 2017-05-31 13:24:08]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2914513002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2017-05-31 13:24:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 14:06:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496237047704220,
"parent_rev": "436d5e22db0b978fc69612f62f8a9432622d8fe1", "commit_rev":
"9afd4e56b91ab92e26ff858c1efda79ec5a8fb59"}

[commit-bot: I haz the power, 2017-05-31 14:06:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496237047704220,
"parent_rev": "f5702814508823c72cbcb22eadc2afc59be38244", "commit_rev":
"93fdbfecc3703f4b1459d8dec0fb412ed508f90a"}

[commit-bot: I haz the power, 2017-05-31 14:07:04]

Description was changed from

==========
Use explicit dividers between preferences in AccountManagementFragment

This CL replaces dividers provided by ListView with explicit ones.
ListView always draws divider after every selectable preference, but in
AccountManagementFragment there are cases when it is necessary to show divider
after non-selectable preference and hide divider after selectable ones.
This CL achieves such a fine-grained control by setting ListView divider to
null and adding explicit dividers where necessary.

BUG=722907
==========

to

==========
Use explicit dividers between preferences in AccountManagementFragment

This CL replaces dividers provided by ListView with explicit ones.
ListView always draws divider after every selectable preference, but in
AccountManagementFragment there are cases when it is necessary to show divider
after non-selectable preference and hide divider after selectable ones.
This CL achieves such a fine-grained control by setting ListView divider to
null and adding explicit dividers where necessary.

BUG=722907

Review-Url: https://codereview.chromium.org/2914513002
Cr-Commit-Position: refs/heads/master@{#475902}
Committed:
https://chromium.googlesource.com/chromium/src/+/93fdbfecc3703f4b1459d8dec0fb...
==========

[commit-bot: I haz the power, 2017-05-31 14:07:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/93fdbfecc3703f4b1459d8dec0fb...