Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2914423002: Network service: move URLLoaderThrottle and ThrottlingURLLoader. (Closed)

Created:
3 years, 6 months ago by yzshen1
Modified:
3 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, vakh+watch_chromium.org, grt+watch_chromium.org, nasko+codewatch_chromium.org, jam, timvolodine, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Network service: move URLLoaderThrottle and ThrottlingURLLoader. The files are moved from content/[public/]chlid/ to content/[public/]common/, so that they can be used in the browser process as well. In follow-up CLs, they will be used by browser-initiated SB checks. BUG=715673 Review-Url: https://codereview.chromium.org/2914423002 Cr-Commit-Position: refs/heads/master@{#477134} Committed: https://chromium.googlesource.com/chromium/src/+/208145bd191e5d51595c96d4173a0c6f4513435b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1007 lines) Patch
M chrome/renderer/chrome_content_renderer_client_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/safe_browsing_url_loader_throttle.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/request_extra_data.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/resource_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/resource_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/child/throttling_url_loader.h View 1 chunk +0 lines, -117 lines 0 comments Download
D content/child/throttling_url_loader.cc View 1 chunk +0 lines, -243 lines 0 comments Download
D content/child/throttling_url_loader_unittest.cc View 1 chunk +0 lines, -560 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + content/common/throttling_url_loader.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/common/throttling_url_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/common/throttling_url_loader_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/child/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/public/child/url_loader_throttle.h View 1 chunk +0 lines, -67 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + content/public/common/url_loader_throttle.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
yzshen1
Hi, John. Would you please take a look? Thanks!
3 years, 6 months ago (2017-06-02 19:44:42 UTC) #3
yzshen1
On 2017/06/02 19:44:42, yzshen1 wrote: > Hi, John. > > Would you please take a ...
3 years, 6 months ago (2017-06-05 16:24:59 UTC) #7
jam
lgtm
3 years, 6 months ago (2017-06-05 19:29:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914423002/1
3 years, 6 months ago (2017-06-05 19:35:48 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 00:47:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/208145bd191e5d51595c96d4173a...

Powered by Google App Engine
This is Rietveld 408576698