Expose the exceptions info in the diagnostics page.

Expose the exceptions info in the diagnostics page.

BUG=
R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/428c0ff59d0a3f66f6abbf576d70615fca5d91ec

[devoncarew, 2017-06-02 16:40:09]

devoncarew@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2017-06-02 16:43:22]

LGTM

https://codereview.chromium.org/2914383002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/collections.dart (right):

https://codereview.chromium.org/2914383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/collections.dart:52: * It will never grow larger
than `capacity`. It's a LIFO queue - the last item
[capacity]

https://codereview.chromium.org/2914383002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/diagnostics.dart (right):

https://codereview.chromium.org/2914383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/diagnostics.dart:515:
buf.writeln('<code>${escape(ex.stackTrace?.toString())}</code>');
toString() is safe to call for Null.

[devoncarew, 2017-06-02 16:51:02]

https://codereview.chromium.org/2914383002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/collections.dart (right):

https://codereview.chromium.org/2914383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/collections.dart:52: * It will never grow larger
than `capacity`. It's a LIFO queue - the last item
On 2017/06/02 16:43:22, scheglov wrote:
> [capacity]

Done.

https://codereview.chromium.org/2914383002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/diagnostics.dart (right):

https://codereview.chromium.org/2914383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/diagnostics.dart:515:
buf.writeln('<code>${escape(ex.stackTrace?.toString())}</code>');
On 2017/06/02 16:43:22, scheglov wrote:
> toString() is safe to call for Null.

Done.

[devoncarew, 2017-06-02 16:57:17]

Description was changed from

==========
Expose the exceptions info in the diagnostics page.

BUG=
==========

to

==========
Expose the exceptions info in the diagnostics page.

BUG=
R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/428c0ff59d0a3f66f6abbf576d70615fca5d91ec
==========

[devoncarew, 2017-06-02 16:57:19]

Committed patchset #2 (id:20001) manually as
428c0ff59d0a3f66f6abbf576d70615fca5d91ec (presubmit successful).

[Brian Wilkerson, 2017-06-02 17:00:47]

lgtm

https://codereview.chromium.org/2914383002/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/2914383002/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/analysis_server.dart:1248: stackTrace =
StackTrace.current;
Or

buffer.writeln();
buffer.write(stackTrace ?? StackTrace.current);

https://codereview.chromium.org/2914383002/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/analysis_server.dart:1260: stackTrace ??=
exception.stackTrace;
stackTrace will never be null at this point (unless you make the change
suggested above)

[devoncarew, 2017-06-02 17:12:59]

https://codereview.chromium.org/2914383002/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/2914383002/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/analysis_server.dart:1260: stackTrace ??=
exception.stackTrace;
On 2017/06/02 17:00:47, Brian Wilkerson wrote:
> stackTrace will never be null at this point (unless you make the change
> suggested above)

I think it can be, if it starts null, and the exception is a CaughtException.

[Brian Wilkerson, 2017-06-02 17:20:28]

https://codereview.chromium.org/2914383002/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/2914383002/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/analysis_server.dart:1260: stackTrace ??=
exception.stackTrace;
Yep. I missed the condition.