Expose the exceptions info in the diagnostics page.

pkg/analysis_server/lib/src/status/diagnostics.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:convert';
 import 'dart:io';
 
 import 'package:analysis_server/protocol/protocol_generated.dart';
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/domain_completion.dart';
 import 'package:analysis_server/src/domain_execution.dart';
 import 'package:analysis_server/src/plugin/plugin_manager.dart';
 import 'package:analysis_server/src/server/http_server.dart';
 import 'package:analysis_server/src/services/completion/completion_performance.dart';
 import 'package:analysis_server/src/socket_server.dart';
 import 'package:analysis_server/src/status/pages.dart';
-import 'package:analyzer/exception/exception.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/instrumentation/instrumentation.dart';
 import 'package:analyzer/source/package_map_resolver.dart';
 import 'package:analyzer/source/sdk_ext.dart';
 import 'package:analyzer/src/context/source.dart';
 import 'package:analyzer/src/dart/analysis/driver.dart';
 import 'package:analyzer/src/dart/analysis/file_state.dart';
 import 'package:analyzer/src/dart/sdk/sdk.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/sdk.dart';
@@ skipping 108 matching lines @@
   List<String> lastPrintedLines = <String>[];
 
   DiagnosticsSite(this.socketServer, this.lastPrintedLines)
       : super('Analysis Server') {
     pages.add(new CompletionPage(this));
     pages.add(new CommunicationsPage(this));
     pages.add(new ContextsPage(this));
     pages.add(new ExecutionDomainPage(this));
     pages.add(new OverlaysPage(this));
     pages.add(new ProfilePage(this));
-    //pages.add(new ExceptionsPage(this));
+    pages.add(new ExceptionsPage(this));
     pages.add(new InstrumentationPage(this));
     pages.add(new PluginsPage(this));
 
     pages.sort(((Page a, Page b) =>
         a.title.toLowerCase().compareTo(b.title.toLowerCase())));
 
     // Add the status page at the beginning.
     pages.insert(0, new StatusPage(this));
 
     // Add non-nav pages.
@@ skipping 332 matching lines @@
         printMilliseconds(tag.elapsedMs),
         printPercentage(percent)
       ]);
     }
 
     tags.forEach(writeRow);
     buf.write('</table>');
   }
 }
 
-// TODO(devoncarew): This is not hooked up.
 class ExceptionsPage extends DiagnosticPageWithNav {
   ExceptionsPage(DiagnosticsSite site)
       : super(site, 'exceptions', 'Exceptions',
             description: 'Exceptions from the analysis server.');
 
-  String get navDetail => exceptions.length.toString();
+  String get navDetail => printInteger(exceptions.length);
 
   @override
   void generateContent(Map<String, String> params) {
     if (exceptions.isEmpty) {
       blankslate('No exceptions encountered!');
     } else {
-      for (CaughtException ex in exceptions) {
-        h3('${ex.exception}');
-        p(ex.toString(), style: 'white-space: pre');
+      for (ServerException ex in exceptions) {
+        h3('Exception ${ex.exception}');
+        p('${escape(ex.message)}<br>${writeOption('fatal', ex.fatal)}',
+            raw: true);
+        pre(() {
+          buf.writeln('<code>${escape(ex.stackTrace?.toString())}</code>');

[scheglov, 2017/06/02 16:43:22]

toString() is safe to call for Null.

[devoncarew, 2017/06/02 16:51:02]

Done.

+        }, classes: "scroll-table");
       }
     }
   }
 
-  // TODO: Implement - read this from a server exception ring buffer.
-  List<CaughtException> get exceptions => [];
+  Iterable<ServerException> get exceptions => server.exceptions.items;
 }
 
 class ContextsPage extends DiagnosticPageWithNav {
   ContextsPage(DiagnosticsSite site)
       : super(site, 'contexts', 'Contexts',
             description:
                 'An analysis context defines the options and the set of sources being analyzed.');
 
   String get navDetail => printInteger(server.driverMap.length);
 
@@ skipping 430 matching lines @@
   return '$name: <code>$value</code><br> ';
 }
 
 String get _sdkVersion {
   String version = Platform.version;
   if (version.contains(' ')) {
     version = version.substring(0, version.indexOf(' '));
   }
   return version;
 }