Make check_gn_headers.py run on Windows

Make check_gn_headers.py run on Windows

BUG=661774
Review-Url: https://codereview.chromium.org/2914323002
Cr-Commit-Position: refs/heads/master@{#478848}
Committed: https://chromium.googlesource.com/chromium/src/+/97580dea9404ad2c8b7916cdf3f5f30670f3d226

[wychen, 2017-06-02 18:07:19]

wychen@chromium.org changed reviewers:
+ brucedawson@chromium.org

[wychen, 2017-06-02 18:07:19]

PTAL. I tested it on a GCE VM.

[brucedawson, 2017-06-12 17:38:40]

Sorry for the delayed response. lgtm with some nits.

https://codereview.chromium.org/2914323002/diff/1/build/check_gn_headers.py
File build/check_gn_headers.py (right):

https://codereview.chromium.org/2914323002/diff/1/build/check_gn_headers.py#n...
build/check_gn_headers.py:51: # Ninja always use "/", even on Windows.
use-> uses

https://codereview.chromium.org/2914323002/diff/1/build/check_gn_headers.py#n...
build/check_gn_headers.py:86: GN_EXE = 'gn.bat' if sys.platform == 'win32' else
'gn'
Why upper-case for GN_EXE and GCLIENT_EXE? Doesn't the style guide say
lower-case?

[wychen, 2017-06-12 21:45:45]

https://codereview.chromium.org/2914323002/diff/1/build/check_gn_headers.py
File build/check_gn_headers.py (right):

https://codereview.chromium.org/2914323002/diff/1/build/check_gn_headers.py#n...
build/check_gn_headers.py:51: # Ninja always use "/", even on Windows.
On 2017/06/12 17:38:40, brucedawson wrote:
> use-> uses

Done.

https://codereview.chromium.org/2914323002/diff/1/build/check_gn_headers.py#n...
build/check_gn_headers.py:86: GN_EXE = 'gn.bat' if sys.platform == 'win32' else
'gn'
On 2017/06/12 17:38:40, brucedawson wrote:
> Why upper-case for GN_EXE and GCLIENT_EXE? Doesn't the style guide say
> lower-case?

Done.

[brucedawson, 2017-06-12 22:07:23]

lgtm

[wychen, 2017-06-12 23:05:47]

The CQ bit was checked by wychen@chromium.org

[wychen, 2017-06-12 23:05:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
brucedawson@chromium.org
Link to the patchset: https://codereview.chromium.org/2914323002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-12 23:06:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 00:52:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497308747820010,
"parent_rev": "4d8a7c16ddb43b19a0768c68ccb2c72400879485", "commit_rev":
"97580dea9404ad2c8b7916cdf3f5f30670f3d226"}

[commit-bot: I haz the power, 2017-06-13 00:52:54]

Description was changed from

==========
Make check_gn_headers.py run on Windows

BUG=661774
==========

to

==========
Make check_gn_headers.py run on Windows

BUG=661774

Review-Url: https://codereview.chromium.org/2914323002
Cr-Commit-Position: refs/heads/master@{#478848}
Committed:
https://chromium.googlesource.com/chromium/src/+/97580dea9404ad2c8b7916cdf3f5...
==========

[commit-bot: I haz the power, 2017-06-13 00:52:58]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/97580dea9404ad2c8b7916cdf3f5...