Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2914303002: [ObjC ARC] Converts ios/chrome/browser/ui/reading_list:unit_tests to ARC. (Closed)

Created:
3 years, 6 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 6 months ago
Reviewers:
gambard, stkhapugin
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/reading_list:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues: - There's a performSelector: usage that I have to (safely) suppress compiler warnings. BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2914303002 Cr-Commit-Position: refs/heads/master@{#476697} Committed: https://chromium.googlesource.com/chromium/src/+/1cda6f2e768bf6c0d443cba6dd05e5c8bcbf9922

Patch Set 1 #

Patch Set 2 : Workaround for performSelector: #

Patch Set 3 : Use pragma to suppress performSelector ARC warning #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -53 lines) Patch
M ios/chrome/browser/ui/reading_list/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/offline_page_native_content_unittest.mm View 4 chunks +14 lines, -13 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm View 1 2 9 chunks +26 lines, -24 lines 2 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_coordinator_unittest.mm View 5 chunks +18 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
pkl (ping after 24h if needed)
stk: ARC conversion gambard: OWNERS review
3 years, 6 months ago (2017-06-01 21:54:43 UTC) #5
stkhapugin
lgtm, but please take a look at my comment. https://codereview.chromium.org/2914303002/diff/30001/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm File ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm (right): https://codereview.chromium.org/2914303002/diff/30001/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm#newcode53 ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm:53: ...
3 years, 6 months ago (2017-06-02 09:52:33 UTC) #6
gambard
lgtm
3 years, 6 months ago (2017-06-02 12:39:24 UTC) #7
pkl (ping after 24h if needed)
I will leave the performSelect: #pragma as is https://codereview.chromium.org/2914303002/diff/30001/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm File ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm (right): https://codereview.chromium.org/2914303002/diff/30001/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm#newcode53 ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm:53: id ...
3 years, 6 months ago (2017-06-02 15:32:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914303002/30001
3 years, 6 months ago (2017-06-02 15:34:22 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 17:02:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/1cda6f2e768bf6c0d443cba6dd05...

Powered by Google App Engine
This is Rietveld 408576698