[ObjC ARC] Converts ios/chrome/browser/ui/reading_list:unit_tests to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/reading_list:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
- There's a performSelector: usage that I have to (safely) suppress compiler warnings.
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2914303002
Cr-Commit-Position: refs/heads/master@{#476697}
Committed: https://chromium.googlesource.com/chromium/src/+/1cda6f2e768bf6c0d443cba6dd05e5c8bcbf9922

[pkl (ping after 24h if needed), 2017-06-01 21:22:21]

The CQ bit was checked by pkl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 21:22:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pkl (ping after 24h if needed), 2017-06-01 21:54:19]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/reading_list:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/reading_list:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
- There's a performSelector: usage that I have to (safely) suppress compiler
warnings.
BUG=624363
TEST=None
==========

[pkl (ping after 24h if needed), 2017-06-01 21:54:42]

pkl@chromium.org changed reviewers:
+ gambard@chromium.org, stkhapugin@chromium.org

[pkl (ping after 24h if needed), 2017-06-01 21:54:43]

stk: ARC conversion
gambard: OWNERS review

[stkhapugin, 2017-06-02 09:52:33]

lgtm, but please take a look at my comment.

https://codereview.chromium.org/2914303002/diff/30001/ios/chrome/browser/ui/r...
File
ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm
(right):

https://codereview.chromium.org/2914303002/diff/30001/ios/chrome/browser/ui/r...
ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm:53:
id mock_delegate_;
This has gone from bare pointer to strong, is this intended?

[gambard, 2017-06-02 12:39:24]

lgtm

[pkl (ping after 24h if needed), 2017-06-02 15:32:55]

I will leave the performSelect: #pragma as is

https://codereview.chromium.org/2914303002/diff/30001/ios/chrome/browser/ui/r...
File
ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm
(right):

https://codereview.chromium.org/2914303002/diff/30001/ios/chrome/browser/ui/r...
ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm:53:
id mock_delegate_;
On 2017/06/02 09:52:33, stkhapugin wrote:
> This has gone from bare pointer to strong, is this intended?

As discussed on IRC, mock_delegate_ should have been strong in the past.

[pkl (ping after 24h if needed), 2017-06-02 15:33:55]

The CQ bit was checked by pkl@chromium.org

[commit-bot: I haz the power, 2017-06-02 15:34:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 17:02:19]

CQ is committing da patch.

Bot data: {"patchset_id": 30001, "attempt_start_ts": 1496417635373600,
"parent_rev": "50557d9c16513478a393d4e04817beca3528e184", "commit_rev":
"1cda6f2e768bf6c0d443cba6dd05e5c8bcbf9922"}

[commit-bot: I haz the power, 2017-06-02 17:02:30]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/reading_list:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
- There's a performSelector: usage that I have to (safely) suppress compiler
warnings.
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/reading_list:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
- There's a performSelector: usage that I have to (safely) suppress compiler
warnings.
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2914303002
Cr-Commit-Position: refs/heads/master@{#476697}
Committed:
https://chromium.googlesource.com/chromium/src/+/1cda6f2e768bf6c0d443cba6dd05...
==========

[commit-bot: I haz the power, 2017-06-02 17:02:31]

Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/1cda6f2e768bf6c0d443cba6dd05...