Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 29143005: Constify SkFlattenable::getFactory(). (Closed)

Created:
7 years, 2 months ago by f(malita)
Modified:
7 years, 2 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Constify SkFlattenable::getFactory(). This allows us to also constify the argument of SkFlattenableWriteBuffer::writeFlattenable() - which I've recently found myself const-casting for no apparent good reason. R=reed@google.com,mtklein@google.com,bungeman@google.com Committed: http://code.google.com/p/skia/source/detail?r=11862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M include/core/SkFlattenable.h View 2 chunks +3 lines, -3 lines 0 comments Download
M include/core/SkFlattenableBuffers.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/effects/SkDashPathEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkFlattenableBuffers.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkOrderedWriteBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkOrderedWriteBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDashPathEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
f(malita)
7 years, 2 months ago (2013-10-18 18:59:37 UTC) #1
reed1
lgtm
7 years, 2 months ago (2013-10-18 19:24:19 UTC) #2
mtklein
On 2013/10/18 19:24:19, reed1 wrote: > lgtm This has always puzzled me. Major +1. lgtm
7 years, 2 months ago (2013-10-18 19:28:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/29143005/1
7 years, 2 months ago (2013-10-18 19:37:39 UTC) #4
commit-bot: I haz the power
Change committed as 11862
7 years, 2 months ago (2013-10-18 19:37:59 UTC) #5
robertphillips
Reverted in r11871 due to Chromium compilation failures. Please see: https://codereview.chromium.org/30973002/
7 years, 2 months ago (2013-10-20 13:43:20 UTC) #6
f(malita)
On 2013/10/20 13:43:20, robertphillips wrote: > Reverted in r11871 due to Chromium compilation failures. Please ...
7 years, 2 months ago (2013-10-21 04:16:11 UTC) #7
robertphillips
7 years, 2 months ago (2013-10-21 12:26:52 UTC) #8
Message was sent while issue was closed.
Relanded in r11876

Powered by Google App Engine
This is Rietveld 408576698