Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2914273004: Add IsSupportedBitstreamAudioCodec() function in MediaClient. (Closed)

Created:
3 years, 6 months ago by AndyWu
Modified:
3 years, 6 months ago
CC:
alokp+watch_chromium.org, chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, jam, lcwu+watch_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add IsSupportedBitstreamAudioCodec() function in MediaClient. This CL is part of enabling (E)AC3 passthrough feature. Add IsSupportedBitstreamAudioCodec() function in MediaClient. BUG=613385 Review-Url: https://codereview.chromium.org/2914273004 Cr-Commit-Position: refs/heads/master@{#477327} Committed: https://chromium.googlesource.com/chromium/src/+/9cc516bf79d5adb8c2425d42b4d4baaf729fd21e

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename #

Total comments: 1

Patch Set 3 : Fix typos #

Patch Set 4 : Fix unittests #

Patch Set 5 : Fix one typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M chromecast/renderer/cast_content_renderer_client.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/renderer/cast_content_renderer_client.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/media/render_media_client.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/render_media_client.cc View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M media/base/key_systems_unittest.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M media/base/media_client.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 36 (26 generated)
AndyWu
3 years, 6 months ago (2017-06-02 22:26:42 UTC) #3
DaleCurtis
lgtm % naming. https://codereview.chromium.org/2914273004/diff/1/content/public/renderer/content_renderer_client.h File content/public/renderer/content_renderer_client.h (right): https://codereview.chromium.org/2914273004/diff/1/content/public/renderer/content_renderer_client.h#newcode274 content/public/renderer/content_renderer_client.h:274: virtual bool IsSupportedBitstreamAudio(media::AudioCodec codec); Seems it ...
3 years, 6 months ago (2017-06-02 22:34:48 UTC) #5
chcunningham
lgtm
3 years, 6 months ago (2017-06-05 18:02:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914273004/20001
3 years, 6 months ago (2017-06-05 18:48:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/455798)
3 years, 6 months ago (2017-06-05 18:57:51 UTC) #12
halliwell
chromecast/ lgtm % spelling and you'll need a content owner. https://codereview.chromium.org/2914273004/diff/20001/content/public/renderer/content_renderer_client.h File content/public/renderer/content_renderer_client.h (right): https://codereview.chromium.org/2914273004/diff/20001/content/public/renderer/content_renderer_client.h#newcode279 ...
3 years, 6 months ago (2017-06-05 19:06:33 UTC) #14
halliwell
chromecast/ lgtm % spelling and you'll need a content owner.
3 years, 6 months ago (2017-06-05 19:06:34 UTC) #15
jochen (gone - plz use gerrit)
lgtm
3 years, 6 months ago (2017-06-06 14:47:24 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914273004/80001
3 years, 6 months ago (2017-06-06 16:57:46 UTC) #33
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 17:30:14 UTC) #36
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/9cc516bf79d5adb8c2425d42b4d4...

Powered by Google App Engine
This is Rietveld 408576698