Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2914273002: Fix crossorigin script module test assertions (Closed)

Created:
3 years, 6 months ago by adamk
Modified:
3 years, 6 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, hiroshige, kouhei (in TOK), tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crossorigin script module test assertions The module/crossorigin.html WPT previously expected different behavior when a "crossorigin" attribute was present on the script element vs when it was missing. But that is incorrect per-spec. Updated the test to expect the script load to be blocked in both cases. BUG=594639 Review-Url: https://codereview.chromium.org/2914273002 Cr-Commit-Position: refs/heads/master@{#476655} Committed: https://chromium.googlesource.com/chromium/src/+/52647ef2089ff4554a6245d2a8ed9dc8699a5f44

Patch Set 1 #

Messages

Total messages: 20 (12 generated)
adamk
3 years, 6 months ago (2017-06-01 19:42:45 UTC) #2
domenic
lgtm
3 years, 6 months ago (2017-06-01 21:00:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914273002/1
3 years, 6 months ago (2017-06-01 21:51:28 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-01 21:51:29 UTC) #11
adamk
+hiroshige for a committer reviewer
3 years, 6 months ago (2017-06-01 21:52:56 UTC) #13
Mike West
LGTM
3 years, 6 months ago (2017-06-02 09:40:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914273002/1
3 years, 6 months ago (2017-06-02 15:10:30 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 15:16:11 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/52647ef2089ff4554a6245d2a8ed...

Powered by Google App Engine
This is Rietveld 408576698