Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2914253002: Disable [TranslateTestCase testTranslateInfobar] (Closed)

Created:
3 years, 6 months ago by michaeldo
Modified:
3 years, 6 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable [TranslateTestCase testTranslateInfobar] TBR=sdefresne@chromium.org BUG=none Review-Url: https://codereview.chromium.org/2914253002 Cr-Commit-Position: refs/heads/master@{#476363} Committed: https://chromium.googlesource.com/chromium/src/+/5fdd27d882d65b574c74fdc6997536891405aceb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/chrome/browser/translate/translate_egtest.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
michaeldo
3 years, 6 months ago (2017-06-01 17:58:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914253002/1
3 years, 6 months ago (2017-06-01 17:58:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5fdd27d882d65b574c74fdc6997536891405aceb
3 years, 6 months ago (2017-06-01 18:34:12 UTC) #6
sdefresne
On 2017/06/01 18:34:12, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 6 months ago (2017-06-02 08:15:44 UTC) #7
sdefresne
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2918073002/ by sdefresne@chromium.org. ...
3 years, 6 months ago (2017-06-02 08:16:06 UTC) #8
michaeldo
On 2017/06/02 08:15:44, sdefresne wrote: > On 2017/06/01 18:34:12, commit-bot: I haz the power wrote: ...
3 years, 6 months ago (2017-06-02 14:54:17 UTC) #9
sdefresne
3 years, 6 months ago (2017-06-02 15:28:01 UTC) #10
Message was sent while issue was closed.
On 2017/06/02 14:54:17, michaeldo wrote:
> On 2017/06/02 08:15:44, sdefresne wrote:
> > On 2017/06/01 18:34:12, commit-bot: I haz the power wrote:
> > > Committed patchset #1 (id:1) as
> > >
> >
>
https://chromium.googlesource.com/chromium/src/+/5fdd27d882d65b574c74fdc69975...
> > 
> > I landed a CL yesterday to fix the test
> > https://chromium-review.googlesource.com/c/521108/ and sent it to the
sheriff
> > for review.
> > It landed two hours before this CLs. I'm unsure why the test was disabled.
> 
> Sorry, I was the U.S. sheriff and wasn't aware of that CL to fix the test.
> (Thank you for the quick fix, please be sure to CC the "other" sheriff if the
> shift times are likely to overlap.) I disabled it after multiple tree failures
> per your notice in IRC after seeing it was never disabled and the tree was
still
> failing. Your fix just missed landing by the time I disabled the test.

No problem. I'll put both sheriff as reviewer next time.

Powered by Google App Engine
This is Rietveld 408576698