Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2914233003: [CRD iOS] Don't attempt to connect to an offline host (Closed)

Created:
3 years, 6 months ago by Yuwei
Modified:
3 years, 6 months ago
Reviewers:
nicholss
CC:
chromium-reviews, ios-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CRD iOS] Don't attempt to connect to an offline host Previously when the user clicks on an offline host, the client will still attempts to connect to it, then it crashes. This CL prevents the client from attempting to connect to an offline host. When the offline host is selected, the client will just show a snack bar message and do nothing else. Review-Url: https://codereview.chromium.org/2914233003 Cr-Commit-Position: refs/heads/master@{#476455} Committed: https://chromium.googlesource.com/chromium/src/+/9c1f5b800d16648826954266f25767a23d75f276

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M remoting/ios/app/remoting_view_controller.mm View 1 chunk +7 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (4 generated)
Yuwei
PTAL thanks!
3 years, 6 months ago (2017-06-01 21:13:29 UTC) #2
nicholss
lgtm https://codereview.chromium.org/2914233003/diff/1/remoting/ios/app/remoting_view_controller.mm File remoting/ios/app/remoting_view_controller.mm (right): https://codereview.chromium.org/2914233003/diff/1/remoting/ios/app/remoting_view_controller.mm#newcode208 remoting/ios/app/remoting_view_controller.mm:208: message.text = @"Host is offline."; Might be overkill ...
3 years, 6 months ago (2017-06-01 21:56:57 UTC) #3
Yuwei
Thanks! https://codereview.chromium.org/2914233003/diff/1/remoting/ios/app/remoting_view_controller.mm File remoting/ios/app/remoting_view_controller.mm (right): https://codereview.chromium.org/2914233003/diff/1/remoting/ios/app/remoting_view_controller.mm#newcode208 remoting/ios/app/remoting_view_controller.mm:208: message.text = @"Host is offline."; On 2017/06/01 21:56:57, ...
3 years, 6 months ago (2017-06-01 22:06:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914233003/1
3 years, 6 months ago (2017-06-01 22:07:55 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 22:23:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c1f5b800d16648826954266f257...

Powered by Google App Engine
This is Rietveld 408576698