Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2914203003: diskcache_perftest: fully use base::EvictFileFromSystemCache on android, (Closed)

Created:
3 years, 6 months ago by Maks Orlovich
Modified:
3 years, 6 months ago
Reviewers:
jkarlin
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

diskcache_perftest: fully use base::EvictFileFromSystemCache on android, now it's available there. BUG=722885 Review-Url: https://codereview.chromium.org/2914203003 Cr-Commit-Position: refs/heads/master@{#476310} Committed: https://chromium.googlesource.com/chromium/src/+/d29ed392cc031d617f582ff019e555e50c311e37

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/disk_cache/disk_cache_perftest.cc View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 10 (4 generated)
Maks Orlovich
3 years, 6 months ago (2017-06-01 15:02:28 UTC) #2
jkarlin
https://codereview.chromium.org/2914203003/diff/1/net/disk_cache/disk_cache_perftest.cc File net/disk_cache/disk_cache_perftest.cc (right): https://codereview.chromium.org/2914203003/diff/1/net/disk_cache/disk_cache_perftest.cc#newcode226 net/disk_cache/disk_cache_perftest.cc:226: // this (currently Linux and Android only). Can you ...
3 years, 6 months ago (2017-06-01 15:15:27 UTC) #3
Maks Orlovich
On 2017/06/01 15:15:27, jkarlin wrote: > https://codereview.chromium.org/2914203003/diff/1/net/disk_cache/disk_cache_perftest.cc > File net/disk_cache/disk_cache_perftest.cc (right): > > https://codereview.chromium.org/2914203003/diff/1/net/disk_cache/disk_cache_perftest.cc#newcode226 > ...
3 years, 6 months ago (2017-06-01 15:17:01 UTC) #4
jkarlin
lgtm
3 years, 6 months ago (2017-06-01 15:29:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914203003/1
3 years, 6 months ago (2017-06-01 15:32:13 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 15:54:59 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d29ed392cc031d617f582ff019e5...

Powered by Google App Engine
This is Rietveld 408576698