Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2914173002: Removing file_thread_task_runner parameter from SerialIoHandler (Closed)

Created:
3 years, 6 months ago by sujith
Modified:
3 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, wfh+watch_chromium.org, jam, darin-cc_chromium.org, tracing+reviews_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed the use of file_thread_task_runner across SerialIoHandler and BattOrAgent. BUG=728448 Review-Url: https://codereview.chromium.org/2914173002 Cr-Commit-Position: refs/heads/master@{#481529} Committed: https://chromium.googlesource.com/chromium/src/+/1f83b935b39059fb1f407857b0da6f4614e16e71

Patch Set 1 #

Patch Set 2 : Removing file_thread_task_runner parameter from SerialIoHandler #

Total comments: 4

Patch Set 3 : Removing file_thread_task_runner parameter from SerialIoHandler #

Patch Set 4 : Removing file_thread_task_runner parameter from SerialIoHandler #

Total comments: 2

Patch Set 5 : Removing file_thread_task_runner parameter from SerialIoHandler #

Patch Set 6 : fix build break #

Patch Set 7 : removed unused variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -57 lines) Patch
M content/browser/tracing/power_tracing_agent.cc View 1 chunk +1 line, -2 lines 0 comments Download
M device/serial/serial_io_handler.h View 1 2 3 4 5 6 4 chunks +0 lines, -7 lines 0 comments Download
M device/serial/serial_io_handler.cc View 1 2 6 chunks +10 lines, -10 lines 0 comments Download
M device/serial/serial_io_handler_posix.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/serial/serial_io_handler_posix.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M device/serial/serial_io_handler_posix_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_io_handler_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/serial/serial_io_handler_win.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M device/serial/test_serial_io_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/browser/api/serial/serial_connection.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/battor_agent/battor_agent.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/battor_agent/battor_agent.cc View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M tools/battor_agent/battor_agent_bin.cc View 1 2 3 4 5 6 6 chunks +4 lines, -10 lines 0 comments Download
M tools/battor_agent/battor_agent_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M tools/battor_agent/battor_connection_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/battor_agent/battor_connection_impl.cc View 2 chunks +1 line, -4 lines 0 comments Download
M tools/battor_agent/battor_connection_impl_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 55 (34 generated)
sujith
PTAL
3 years, 6 months ago (2017-06-01 11:22:03 UTC) #3
Shanmuga Pandi
peer l-g-t-m.
3 years, 6 months ago (2017-06-01 11:53:37 UTC) #5
sujith
Hi All, PTAL
3 years, 6 months ago (2017-06-01 12:05:52 UTC) #8
Reilly Grant (use Gerrit)
Thank you for your contribution. Please see my comments below. In addition, I have removed ...
3 years, 6 months ago (2017-06-01 13:48:21 UTC) #10
sujith
changes done as suggested. PTAL https://codereview.chromium.org/2914173002/diff/20001/device/serial/serial_io_handler.cc File device/serial/serial_io_handler.cc (left): https://codereview.chromium.org/2914173002/diff/20001/device/serial/serial_io_handler.cc#oldcode68 device/serial/serial_io_handler.cc:68: base::ThreadTaskRunnerHandle::Get())); On 2017/06/01 13:48:21, ...
3 years, 6 months ago (2017-06-01 14:57:31 UTC) #11
Reilly Grant (use Gerrit)
Please fix the compilation issues reported by the CQ dry run.
3 years, 6 months ago (2017-06-06 21:10:06 UTC) #16
charliea (OOO until 10-5)
I defer to Reilly whether the changes to SerialIoHandler::Open() and ::Close() are correct, but I ...
3 years, 6 months ago (2017-06-07 15:23:30 UTC) #17
sujith
@charliea, @Reilly Grant, Changes done as suggested. PTAL
3 years, 6 months ago (2017-06-07 15:39:10 UTC) #20
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2914173002/diff/60001/tools/battor_agent/battor_agent_bin.cc File tools/battor_agent/battor_agent_bin.cc (right): https://codereview.chromium.org/2914173002/diff/60001/tools/battor_agent/battor_agent_bin.cc#newcode333 tools/battor_agent/battor_agent_bin.cc:333: base::Thread file_thread_; This field should be replaced with a ...
3 years, 6 months ago (2017-06-07 15:48:56 UTC) #21
sujith
Hi All, PTAL https://codereview.chromium.org/2914173002/diff/60001/tools/battor_agent/battor_agent_bin.cc File tools/battor_agent/battor_agent_bin.cc (right): https://codereview.chromium.org/2914173002/diff/60001/tools/battor_agent/battor_agent_bin.cc#newcode333 tools/battor_agent/battor_agent_bin.cc:333: base::Thread file_thread_; On 2017/06/07 15:48:56, Reilly ...
3 years, 6 months ago (2017-06-08 06:36:38 UTC) #28
charliea (OOO until 10-5)
lgtm for tools/battor_agent
3 years, 6 months ago (2017-06-09 19:41:00 UTC) #29
Reilly Grant (use Gerrit)
lgtm
3 years, 6 months ago (2017-06-09 19:44:02 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914173002/80001
3 years, 6 months ago (2017-06-10 05:41:03 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/460835)
3 years, 6 months ago (2017-06-10 05:48:33 UTC) #34
sujith
hi All, PTAL
3 years, 6 months ago (2017-06-14 14:54:02 UTC) #43
sujith
Hi All, PTAL. @primiano tucci, could you please check from content/browser/tracing side?
3 years, 6 months ago (2017-06-21 06:44:13 UTC) #44
Primiano Tucci (use gerrit)
RS-LGTM on content/browser/tracing/power_tracing_agent.cc, assuming charliea@ is fine with this.
3 years, 6 months ago (2017-06-21 08:58:42 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914173002/120001
3 years, 6 months ago (2017-06-22 07:21:12 UTC) #48
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/473629)
3 years, 6 months ago (2017-06-22 07:59:59 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914173002/120001
3 years, 6 months ago (2017-06-22 13:42:56 UTC) #52
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 14:37:17 UTC) #55
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/1f83b935b39059fb1f407857b0da...

Powered by Google App Engine
This is Rietveld 408576698