Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2914163003: Add a command-line flag for overriding variations country. (Closed)

Created:
3 years, 6 months ago by Alexei Svitkine (slow)
Modified:
3 years, 6 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a command-line flag for overriding variations country. BUG=725294 Review-Url: https://codereview.chromium.org/2914163003 Cr-Commit-Position: refs/heads/master@{#476797} Committed: https://chromium.googlesource.com/chromium/src/+/424a0fd2d03d63853f57258fdbd08ba5751dae17

Patch Set 1 #

Patch Set 2 : Add missing include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M components/variations/service/variations_service.cc View 1 5 chunks +15 lines, -6 lines 0 comments Download
M components/variations/variations_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/variations/variations_switches.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Alexei Svitkine (slow)
3 years, 6 months ago (2017-06-02 00:21:18 UTC) #4
rkaplow
lgtm
3 years, 6 months ago (2017-06-02 18:03:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914163003/20001
3 years, 6 months ago (2017-06-02 18:08:57 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 21:22:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/424a0fd2d03d63853f57258fdbd0...

Powered by Google App Engine
This is Rietveld 408576698