Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 2914103002: Remove usages of XInternAtom (Closed)
Patch Set: Address sadrul and sergeyu comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/host/ash_window_tree_host_x11.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 8a81bb0babc1d3961b1dfea2fa5894d6ce306bad..64dad0d7f7347a5e4eb59490d864e419cc77ab12 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -188,6 +188,17 @@ _BANNED_CPP_FUNCTIONS = (
r"^gpu[\\\/].*\.cc$",
),
),
+ (
+ r'XInternAtom|xcb_intern_atom',
+ (
+ 'Use ui::GetAtom() or ui::X11AtomCache::GetAtom() instead of',
+ 'interning atoms directly.',
+ ),
+ True,
+ (
+ r"^ui[\\\/]gfx[\\\/]x[\\\/]x11_atom_cache\.cc$",
+ ),
+ ),
(
'ScopedAllowIO',
(
« no previous file with comments | « no previous file | ash/host/ash_window_tree_host_x11.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698