Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: PRESUBMIT.py

Issue 2914103002: Remove usages of XInternAtom (Closed)
Patch Set: Address sadrul and sergeyu comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ash/host/ash_window_tree_host_x11.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 'an XDisplay other than gfx::GetXDisplay().', 182 'an XDisplay other than gfx::GetXDisplay().',
183 ), 183 ),
184 True, 184 True,
185 ( 185 (
186 r"^ui[\\\/]gl[\\\/].*\.cc$", 186 r"^ui[\\\/]gl[\\\/].*\.cc$",
187 r"^media[\\\/]gpu[\\\/].*\.cc$", 187 r"^media[\\\/]gpu[\\\/].*\.cc$",
188 r"^gpu[\\\/].*\.cc$", 188 r"^gpu[\\\/].*\.cc$",
189 ), 189 ),
190 ), 190 ),
191 ( 191 (
192 r'XInternAtom|xcb_intern_atom',
193 (
194 'Use ui::GetAtom() or ui::X11AtomCache::GetAtom() instead of',
195 'interning atoms directly.',
196 ),
197 True,
198 (
199 r"^ui[\\\/]gfx[\\\/]x[\\\/]x11_atom_cache\.cc$",
200 ),
201 ),
202 (
192 'ScopedAllowIO', 203 'ScopedAllowIO',
193 ( 204 (
194 'New code should not use ScopedAllowIO. Post a task to the blocking', 205 'New code should not use ScopedAllowIO. Post a task to the blocking',
195 'pool or the FILE thread instead.', 206 'pool or the FILE thread instead.',
196 ), 207 ),
197 True, 208 True,
198 ( 209 (
199 r"^base[\\\/]memory[\\\/]shared_memory_posix\.cc$", 210 r"^base[\\\/]memory[\\\/]shared_memory_posix\.cc$",
200 r"^base[\\\/]process[\\\/]internal_aix\.cc$", 211 r"^base[\\\/]process[\\\/]internal_aix\.cc$",
201 r"^base[\\\/]process[\\\/]process_linux\.cc$", 212 r"^base[\\\/]process[\\\/]process_linux\.cc$",
(...skipping 2262 matching lines...) Expand 10 before | Expand all | Expand 10 after
2464 output_api, 2475 output_api,
2465 json_url='http://chromium-status.appspot.com/current?format=json')) 2476 json_url='http://chromium-status.appspot.com/current?format=json'))
2466 2477
2467 results.extend( 2478 results.extend(
2468 input_api.canned_checks.CheckPatchFormatted(input_api, output_api)) 2479 input_api.canned_checks.CheckPatchFormatted(input_api, output_api))
2469 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2480 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2470 input_api, output_api)) 2481 input_api, output_api))
2471 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2482 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2472 input_api, output_api)) 2483 input_api, output_api))
2473 return results 2484 return results
OLDNEW
« no previous file with comments | « no previous file | ash/host/ash_window_tree_host_x11.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698