Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2914083002: Move InputRouterImpl::Config to InputRouter::Config (Closed)

Created:
3 years, 6 months ago by dtapuska
Modified:
3 years, 6 months ago
Reviewers:
chongz
CC:
chromium-reviews, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move InputRouterImpl::Config to InputRouter::Config This allows an alternate implementation to be provided. BUG=722928 Review-Url: https://codereview.chromium.org/2914083002 Cr-Commit-Position: refs/heads/master@{#476659} Committed: https://chromium.googlesource.com/chromium/src/+/e265c53b04547e9d78621758c423524bea89c7f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M content/browser/renderer_host/input/input_router.h View 2 chunks +8 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/input_router_config_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_config_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
dtapuska
3 years, 6 months ago (2017-05-31 20:23:22 UTC) #3
chongz
LGTM. Talked offline about the big picture, sounds great!
3 years, 6 months ago (2017-05-31 21:15:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914083002/1
3 years, 6 months ago (2017-06-02 12:49:58 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 15:21:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e265c53b04547e9d78621758c423...

Powered by Google App Engine
This is Rietveld 408576698