Settings: Network: Closure cleanup

Settings: Network: Closure cleanup

This is just some closure compilation cleanup of some older JS code
in preparation for merging the Cellular and Tether subpages.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2914053002
Cr-Commit-Position: refs/heads/master@{#476117}
Committed: https://chromium.googlesource.com/chromium/src/+/5f9161e0e544c94de7a182b3c7a502b834834986

[stevenjb, 2017-05-31 18:51:39]

Description was changed from

==========
Settings: Network: Closure cleanup

This is just some closure compilation cleanup of some older JS code
in preparation for merging the Cellular and Tether subpages.

BUG=none
==========

to

==========
Settings: Network: Closure cleanup

This is just some closure compilation cleanup of some older JS code
in preparation for merging the Cellular and Tether subpages.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-05-31 19:01:46]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[stevenjb, 2017-05-31 19:01:46]

https://codereview.chromium.org/2914053002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/network_summary.js (left):

https://codereview.chromium.org/2914053002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/network_summary.js:247: *    
Optional list of state properties for all available devices.
This is no longer optional, this is now only called from getnetworkLists_, and
networkingPrivate.getDeviceStates always returns an Array.

[michaelpg, 2017-05-31 20:18:48]

lgtm

[stevenjb, 2017-05-31 20:24:07]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-05-31 20:25:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 23:29:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 23:29:05]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[stevenjb, 2017-05-31 23:39:45]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-05-31 23:40:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 00:46:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496273985341980,
"parent_rev": "d553d8e2aaf62876c4f810b973e248d3d31f0d11", "commit_rev":
"5f9161e0e544c94de7a182b3c7a502b834834986"}

[commit-bot: I haz the power, 2017-06-01 00:47:08]

Description was changed from

==========
Settings: Network: Closure cleanup

This is just some closure compilation cleanup of some older JS code
in preparation for merging the Cellular and Tether subpages.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings: Network: Closure cleanup

This is just some closure compilation cleanup of some older JS code
in preparation for merging the Cellular and Tether subpages.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2914053002
Cr-Commit-Position: refs/heads/master@{#476117}
Committed:
https://chromium.googlesource.com/chromium/src/+/5f9161e0e544c94de7a182b3c7a5...
==========

[commit-bot: I haz the power, 2017-06-01 00:47:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5f9161e0e544c94de7a182b3c7a5...