Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 291403002: Remove some RenderProcessHost::IsGuest call sites (Closed)

Created:
6 years, 7 months ago by Fady Samuel
Modified:
6 years, 7 months ago
Reviewers:
jam, lazyboy
CC:
chromium-reviews, davidben+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, vsevik, creis+watch_chromium.org, tburkard+watch_chromium.org, nasko+codewatch_chromium.org, jam, yurys, gavinp+prer_chromium.org, dominich+watch_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove some RenderProcessHost::IsGuest call sites This CL removes some of the callsites to RenderProcessHost::IsGuest. BUG=364141, 330264 TBR=benm@chromium.org for trivial android_webview change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272830

Patch Set 1 #

Patch Set 2 : More call sites removed #

Total comments: 2

Patch Set 3 : Addressed nit #

Patch Set 4 : cleanup #

Patch Set 5 : Fixed Android build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -45 lines) Patch
M android_webview/browser/aw_content_browser_client.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_targets_ui.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/guest_view/guest_view_base.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/guest_view_base.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_link_manager.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/task_manager/extension_information.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_message_filter.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_message_filter.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/speech/speech_recognition_dispatcher_host.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/speech/speech_recognition_dispatcher_host.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 3 3 chunks +7 lines, -4 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
Fady Samuel
Some code cleanup.
6 years, 7 months ago (2014-05-22 15:47:43 UTC) #1
Fady Samuel
6 years, 7 months ago (2014-05-23 15:00:55 UTC) #2
jam
lgtm
6 years, 7 months ago (2014-05-23 15:19:22 UTC) #3
lazyboy
lgtm https://codereview.chromium.org/291403002/diff/20001/chrome/browser/devtools/devtools_targets_ui.cc File chrome/browser/devtools/devtools_targets_ui.cc (right): https://codereview.chromium.org/291403002/diff/20001/chrome/browser/devtools/devtools_targets_ui.cc#newcode168 chrome/browser/devtools/devtools_targets_ui.cc:168: if (!!GuestViewBase::FromWebContents(web_contents) || As noted offline, add a ...
6 years, 7 months ago (2014-05-23 15:20:12 UTC) #4
Fady Samuel
Done. CQ'ing. https://codereview.chromium.org/291403002/diff/20001/chrome/browser/devtools/devtools_targets_ui.cc File chrome/browser/devtools/devtools_targets_ui.cc (right): https://codereview.chromium.org/291403002/diff/20001/chrome/browser/devtools/devtools_targets_ui.cc#newcode168 chrome/browser/devtools/devtools_targets_ui.cc:168: if (!!GuestViewBase::FromWebContents(web_contents) || On 2014/05/23 15:20:13, lazyboy ...
6 years, 7 months ago (2014-05-23 15:35:58 UTC) #5
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 7 months ago (2014-05-23 15:44:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/291403002/50001
6 years, 7 months ago (2014-05-23 15:45:28 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 18:33:07 UTC) #8
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 7 months ago (2014-05-23 18:45:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/291403002/70001
6 years, 7 months ago (2014-05-23 18:46:03 UTC) #10
Fady Samuel
The CQ bit was unchecked by fsamuel@chromium.org
6 years, 7 months ago (2014-05-23 19:16:25 UTC) #11
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 7 months ago (2014-05-23 19:16:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/291403002/70001
6 years, 7 months ago (2014-05-23 19:17:27 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 20:48:37 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 21:26:35 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/156648)
6 years, 7 months ago (2014-05-23 21:26:36 UTC) #16
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 7 months ago (2014-05-26 13:45:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/291403002/70001
6 years, 7 months ago (2014-05-26 13:46:18 UTC) #18
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 15:50:29 UTC) #19
Message was sent while issue was closed. 
Change committed as 272830

Powered by Google App Engine
This is Rietveld 408576698